Release proposal: node-gyp@6.0.1 #1935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaocgreis
approved these changes
Oct 24, 2019
richardlau
approved these changes
Oct 24, 2019
|
I believe that we should get #1937 in here. |
cclauss
requested changes
Oct 27, 2019
There was a problem hiding this comment.
I would advocate that we add:
Finish decode stdout on Python 3 #1937 Finish decode stdout on Python 3 (merged)Fix TypeError in XcodeVersion() #1939 Fix TypeError in XcodeVersion() (merged)- build: Add macOS_Catalina.md document #1940 build: Add macOS_Catalina.md document (needs reviews)
4 tasks
|
Updated OP with latest CHANGELOG. I'll put #1940 in here too unless there's further objections in there. So last call on objections, amendments, whatever else, otherwise I'll publish this within 24 hours. |
PR-URL: #1935 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg
force-pushed
the
rvagg/v6.0.1-proposal
branch
from
f7e7f54
to
3cf36ff
Compare
gengjiawen
approved these changes
Nov 1, 2019
|
Is there a plan to sync those change to |
|
published |
rvagg
added a commit
that referenced
this pull request
Nov 1, 2019
PR-URL: #1935 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com>
This was referenced Nov 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing huge, but we could clear some backlog. The dependencies update might be cause for concern if someone really cares about what dependencies are pulled in, there might also be a usecase we haven't tested for that breaks with this change. On the surface it's hard to make a case for anything other than semver-patch though I think.
1b11be63cc] - gyp: python3 fixes: utf8 decode, use of 'None' in eval (Wilfried Goesgens) #1925c0282daa48] - gyp: iteritems() -> items() in compile_commands_json.py (cclauss) #1947d8e09a1b6a] - gyp: make cmake python3 compatible (gengjiawen) #19449c0f3404f0] - gyp: fix TypeError in XcodeVersion() (Christian Clauss) #1939bb2eb72a3f] - gyp: finish decode stdout on Python 3 (Christian Clauss) #1937f0693413d9] - src,win: allow 403 errors for arm64 node.lib (Richard Lau) #1934c60c22de58] - deps: update deps to roughly match current npm@6 (Rod Vagg) #1920b91718eefc] - test: upgrade Linux Travis CI to Python 3.8 (Christian Clauss) #19233538a317b6] - doc: adjustments to the README.md for new users (Dan Pike) #19194fff8458c0] - travis: ignore failedbrew upgrade npm, update xcode (Christian Clauss) #193260e4488f08] - build: avoid bare exceptions in xcode_emulation.py (Christian Clauss) #1932032db2a2d0] - lib,install: always download SHA sums on Windows (Sam Hughes) #19265a83630c33] - travis: add Windows + Python 3.8 to the mix (Rod Vagg) #1921