Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update deps, match to npm@7, upgrade to tap 14 #2126

Closed
wants to merge 2 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented May 13, 2020

semver, tar and which were the major bumps in here, but none had breaking APIs that we touch, thankfully.

I've matched the ranges to npm@7's current ranges, as seen @ https://github.com/npm/cli/blob/release/v7.0.0-beta/package.json, so for some of them they're not the actual latest but they're only out by a patch release or two.

Updated tap to v14, which drops support for older versions of Node.js, but it runs nicer in parallel and gives automatic coverage reporting (which is dismal, but we knew that).

@rvagg
Copy link
Member Author

rvagg commented May 13, 2020

semver-major because some of the dependencies remove support for unsupported versions of Node.js, so this will not be a happy jump for users who aren't on 10 at least.

@rvagg
Copy link
Member Author

rvagg commented May 18, 2020

any reviews?

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@cclauss
Copy link
Contributor

cclauss commented May 18, 2020

Why the Travis Windows failures?

@rvagg
Copy link
Member Author

rvagg commented May 19, 2020

Sigh, typical useless output on compiling the test addon.

gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin\MSBuild.exe
5221          
5222              gyp info spawn args [
5223          
5224              gyp info spawn args   'build/binding.sln',
5225          
5226              gyp info spawn args   '/nologo',
5227          
5228              gyp info spawn args   '/p:Configuration=Release;Platform=x64'
5229          
5230              gyp info spawn args ]
5231          
5232              gyp ERR! build error 
5233          
5234              gyp ERR! stack Error: `C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin\MSBuild.exe` failed with exit code: 1
5235          
5236              gyp ERR! stack     at ChildProcess.onExit (C:\Users\travis\build\nodejs\node-gyp\lib\build.js:21:656)
5237          
5238              gyp ERR! stack     at ChildProcess.emit (events.js:310:20)
5239          
5240              gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
5241          
5242              gyp ERR! System Windows_NT 10.0.17763
5243          
5244              gyp ERR! command "C:\\ProgramData\\nvs\\node\\12.16.3\\x64\\node.exe" "C:\\Users\\travis\\build\\nodejs\\node-gyp\\bin\\node-gyp.js" "rebuild" "-C" "C:\\Users\\travis\\build\\nodejs\\node-gyp\\test\\node_modules\\hello_world" "--loglevel=verbose"
5245          

I've rerun the tests twice now with different runners failing.

@rvagg
Copy link
Member Author

rvagg commented May 25, 2020

I've backed out the tap@14 upgrade and tap@12 seems to have stabilised things. It's probably due to the parallel processing tap@14 tries to do. There seems to be a flaky Python test in there though, https://travis-ci.com/github/nodejs/node-gyp/jobs/339548918, aside from that I think this is good to go.

rvagg added a commit that referenced this pull request May 26, 2020
PR-URL: #2126
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
@rvagg rvagg closed this May 26, 2020
@rvagg rvagg deleted the rvagg/update-deps branch May 26, 2020 04:59
@rvagg
Copy link
Member Author

rvagg commented May 26, 2020

d45438a

@rvagg rvagg mentioned this pull request May 26, 2020
rvagg added a commit that referenced this pull request May 27, 2020
PR-URL: #2126
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants