-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update deps, match to npm@7, upgrade to tap 14 #2126
Conversation
semver-major because some of the dependencies remove support for unsupported versions of Node.js, so this will not be a happy jump for users who aren't on 10 at least. |
any reviews? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Why the Travis Windows failures? |
Sigh, typical useless output on compiling the test addon.
I've rerun the tests twice now with different runners failing. |
I've backed out the tap@14 upgrade and tap@12 seems to have stabilised things. It's probably due to the parallel processing tap@14 tries to do. There seems to be a flaky Python test in there though, https://travis-ci.com/github/nodejs/node-gyp/jobs/339548918, aside from that I think this is good to go. |
PR-URL: #2126 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>
PR-URL: #2126 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>
semver, tar and which were the major bumps in here, but none had breaking APIs that we touch, thankfully.
I've matched the ranges to npm@7's current ranges, as seen @ https://github.com/npm/cli/blob/release/v7.0.0-beta/package.json, so for some of them they're not the actual latest but they're only out by a patch release or two.
Updated tap to v14, which drops support for older versions of Node.js, but it runs nicer in parallel and gives automatic coverage reporting (which is dismal, but we knew that).