Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about Python v3.12 not working on windows #2912

Closed
wants to merge 1 commit into from
Closed

Warn about Python v3.12 not working on windows #2912

wants to merge 1 commit into from

Conversation

bertyhell
Copy link
Contributor

@bertyhell bertyhell commented Oct 11, 2023 •
edited
Loading

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

relates to:

@bertyhell bertyhell changed the title Warn about v3.12 on windows breaking Warn about Python v3.12 not working on windows Oct 11, 2023
StefanStojanovic
StefanStojanovic approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as it is reverted after Python v3.12 becomes compatible with Windows in node-gyp.

@cclauss cclauss mentioned this pull request Oct 20, 2023
Merged
@DeeDeeG DeeDeeG mentioned this pull request Oct 27, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bertyhell @StefanStojanovic