Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gyp): update gyp to v0.16.1 #2923

Merged
merged 15 commits into from
Oct 28, 2023
Merged

Conversation

DeeDeeG
Copy link
Contributor

@DeeDeeG DeeDeeG commented Oct 27, 2023

Checklist

  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
    • (NOTE: The PR title does, which is enough if this is squash-and-merged. And otherwise, my own personal commits do. Some commits from before mine do not.)

Description of change

Bump gyp-next to v0.16.1. (nodejs/gyp-next@v0.14.0...v0.16.1)

The biggest reason for bumping to newer gyp-next at the moment is for Python 3.12 support, in my opinion.

Refs

PRs:
Resolves: #2912
Resolves: #2909
Resolves: #2825

Issues:
Resolves: #2915
Resolves: #2869

Credit

Most of this work was done by others. I based this PR's branch off of @rzhao271's branch for the gyp-next v0.15.1 PR #2909. See the gyp-next repo for the various contributors over there.

Reviewers?

Pinging previously active folks around this gyp-next bump, who are probably waiting for this to PR be posted: @rzhao271, @cclauss, @lukekarrys

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor bits but this looks good to me.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.11.6 Missing distutils module distutils is removed in Python 3.12
4 participants