dep: Update graceful-fs dependency to the latest #714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ | |||
| "dependencies": { | |||
| "fstream": "^1.0.0", | |||
| "glob": "3 || 4", | |||
| "graceful-fs": "3", | |||
| "graceful-fs": "4.1.2", | |||
There was a problem hiding this comment.
@bnoordhuis Sure. Done :-)
|
LGTM |
|
LGTM if it works |
|
@thefourtheye Do you have a commit bit or should I land it for you? |
graceful-fs used to monkey-patch node's core fs module. This has been fixed in the version 4.
|
@bnoordhuis I had to update my email in the commit log and its done now. I don't have commit access to this repo, so you can land this. |
bnoordhuis
pushed a commit
that referenced
this pull request
Sep 6, 2015
graceful-fs used to monkey-patch node's core fs module. This has been fixed in version 4. PR-URL: #714 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Thanks Sakthipriyan, landed in 1ea7ed0. Let me know if you plan to work on node-gyp more and I'll give you your commit bit. |
|
@bnoordhuis Sure. I ll start by monitoring the PRs and issues. Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graceful-fs used to monkey-patch node's core fs module.
This has been fixed in the version 4.
This might also fix nodejs/node#2714 (comment)