Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Restore uppercase C++ method names #127

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Conversation

richardlau
Copy link
Member

fabac78 changed the exported C++ method names to start with a lower case
character to match the name exported to JavaScript land. This turns out
to be unnecessary if Nan::SetMethod() is used instead of
NAN_EXPORT(). Restore the original casing of the C++ methods to be
consistent with the non-exported C++ methods.

Refs: #125 (comment)

cc @sam-github

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fabac78 changed the exported C++ method names to start with a lower case
character to match the name exported to JavaScript land. This turns out
to be unnecessary if `Nan::SetMethod()` is used instead of
`NAN_EXPORT()`. Restore the original casing of the C++ methods to be
consistent with the non-exported C++ methods.

PR-URL: nodejs#127
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants