Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
v8: remove optimization switches
Browse files Browse the repository at this point in the history
Remove compiler switches from $(TOPLEVEL)/deps/v8/build/common.gypi, we set
them globally in $(TOPLEVEL)/common.gypi.

Commit 29d12c7 accidentally reintroduced the switches again. In particular,
the 'cflags!': ['-O2','-Os'] section forced building V8 without any
optimizations, resulting in a steep (~66%) performance drop on some benchmarks.

Fixes #4191.
  • Loading branch information
bnoordhuis committed Oct 24, 2012
1 parent 28e6403 commit 4b8629d
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions deps/v8/build/common.gypi
Expand Up @@ -339,16 +339,6 @@
'conditions': [
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd" \
or OS=="android"', {
'cflags!': [
'-O2',
'-Os',
],
'cflags': [
'-fdata-sections',
'-ffunction-sections',
'-fomit-frame-pointer',
'-O3',
],
'conditions': [
[ 'gcc_version==44 and clang==0', {
'cflags': [
Expand Down

0 comments on commit 4b8629d

Please sign in to comment.