Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

bench: big performance drop in http_simple_auto #4191

Closed
bnoordhuis opened this issue Oct 24, 2012 · 4 comments
Closed

bench: big performance drop in http_simple_auto #4191

bnoordhuis opened this issue Oct 24, 2012 · 4 comments
Assignees
@bnoordhuis
Labels
benchmark

Comments

@bnoordhuis
Copy link
Member 

$ node benchmark/http_simple_auto -k -c 500 -n 200000 bytes/64
v0.8    7100 req/s
master  6200 req/s

master consistently scores a lot lower. Investigate.
@ghost ghost assigned bnoordhuis Oct 24, 2012
@bnoordhuis
Copy link
Member Author

It looks like V8 is getting built with optimizations disabled. Investigating.

@bnoordhuis
Copy link
Member Author 

$ out/Release/node benchmark/http_simple_auto -k -c 500 -n 200000 bytes/64 | grep Req
Requests per second:    21677.40 [#/sec] (mean)

3.5x speedup. Not bad. :-)

@langpavel
Copy link

Fixed?
v0.8.12:

Keep-Alive requests:    200000
Total transferred:      38000000 bytes
HTML transferred:       12800000 bytes
Requests per second:    9903.01 [#/sec] (mean)

master at fa94f0f:

Keep-Alive requests:    200000
Total transferred:      38000000 bytes
HTML transferred:       12800000 bytes
Requests per second:    2983.42 [#/sec] (mean)

@bnoordhuis
Copy link
Member Author

Yep. Fixed in 4b8629d , not yet merged into master.

bnoordhuis added a commit that referenced this issue Jun 26, 2013
@bnoordhuis @isaacs
v8: remove optimization switches
ca39767 
Remove compiler switches from $(TOPLEVEL)/deps/v8/build/common.gypi, we set
them globally in $(TOPLEVEL)/common.gypi.

Commit 29d12c7 accidentally reintroduced the switches again. In particular,
the 'cflags!': ['-O2','-Os'] section forced building V8 without any
optimizations, resulting in a steep (~66%) performance drop on some benchmarks.

Fixes #4191.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bnoordhuis bnoordhuis

Labels
benchmark
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@langpavel @bnoordhuis