This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Datagram socket refactor. Add tests and documentation.
Support setTTL() and setBroadcast() socket options.
- Loading branch information
Showing
8 changed files
with
547 additions
and
252 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
4e50197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build fails under Debian Squeeze x64, 2-4 cores:
4e50197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that. I'll take a look.
4e50197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found this interesting post about sockaddr_un structure :
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=187391#114
4e50197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sadly, sun_path is not null terminated on OSX, but it is on Linux. I've almost got a fix for this.
4e50197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to make us test it :)
4e50197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed a fix to my repo that compiles and makes tests pass on OSX and Linux:
http://github.com/mranney/node/commit/47b4718105ac36668c194036c721ba3e2f0061b6
Hopefully will be picked up soon. Sorry for the hassle.
4e50197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, works well for me (debian/sid)
4e50197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This works. But when fix be implemented to upstream?