Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

udp_wrap: slab space is not reclaimed in recv callback #3010

Closed
piscisaureus opened this issue Mar 26, 2012 · 2 comments
Closed

udp_wrap: slab space is not reclaimed in recv callback #3010

piscisaureus opened this issue Mar 26, 2012 · 2 comments
Assignees
@bnoordhuis
Labels
dgram libuv-integration

Comments

@piscisaureus
Copy link

The handle_that_last_alloced variable is tracked properly, but we don't actually use it to reclaim slab space in the recv callback. This leads to subpar udp performance, mostly due to excessive garbage collection triggered by Buffer::New.

See http://ranney.com/metrics.svg .
@ghost ghost assigned bnoordhuis Mar 26, 2012
@bnoordhuis
Copy link
Member

Related to #2981.

@bnoordhuis
Copy link
Member

Fixed in 1ab95a5.

richardlau pushed a commit to ibmruntimes/node that referenced this issue Oct 6, 2015
@rvagg
2015-10-05, Version 4.1.2 (Stable) Release
820735d 
Notable changes

* http:
  - Fix out-of-order 'finish' event bug in pipelining that can abort
    execution, fixes DoS vulnerability CVE-2015-7384
    (Fedor Indutny) nodejs#3128
  - Account for pending response data instead of just the data on the
    current request to decide whether pause the socket or not
    (Fedor Indutny) nodejs#3128
* libuv: Upgraded from v1.7.4 to v1.7.5, see release notes for details
  (Saúl Ibarra Corretgé) nodejs#3010
  - A better rwlock implementation for all Windows versions
  - Improved AIX support
* v8:
  - Upgraded from v4.5.103.33 to v4.5.103.35 (Ali Ijaz Sheikh) nodejs#3117
  - Backported f782159 from v8's upstream to help speed up Promise
    introspection (Ben Noordhuis) nodejs#3130
  - Backported c281c15 from v8's upstream to add JSTypedArray length
    in post-mortem metadata (Julien Gilli) nodejs#3031

PR-URL: nodejs/node#3128
richardlau pushed a commit to ibmruntimes/node that referenced this issue Oct 6, 2015
@rvagg
2015-10-05, Version 4.1.2 (Stable) Release
85df6ad 
Notable changes

* http:
  - Fix out-of-order 'finish' event bug in pipelining that can abort
    execution, fixes DoS vulnerability CVE-2015-7384
    (Fedor Indutny) nodejs#3128
  - Account for pending response data instead of just the data on the
    current request to decide whether pause the socket or not
    (Fedor Indutny) nodejs#3128
* libuv: Upgraded from v1.7.4 to v1.7.5, see release notes for details
  (Saúl Ibarra Corretgé) nodejs#3010
  - A better rwlock implementation for all Windows versions
  - Improved AIX support
* v8:
  - Upgraded from v4.5.103.33 to v4.5.103.35 (Ali Ijaz Sheikh) nodejs#3117
  - Backported f782159 from v8's upstream to help speed up Promise
    introspection (Ben Noordhuis) nodejs#3130
  - Backported c281c15 from v8's upstream to add JSTypedArray length
    in post-mortem metadata (Julien Gilli) nodejs#3031

PR-URL: nodejs/node#3128
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bnoordhuis bnoordhuis

Labels
dgram libuv-integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@piscisaureus @bnoordhuis