Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Added backlog parameter to listen() #3130

Closed
wants to merge 6 commits into from
Closed

Added backlog parameter to listen() #3130

wants to merge 6 commits into from

Conversation

erikdubbelboer
Copy link

See #1496

@erikdubbelboer erikdubbelboer mentioned this pull request Apr 18, 2012
Closed
@bnoordhuis
Copy link
Member

The patch needs some cleanup. Can you add a test or two?

@erikdubbelboer
Copy link
Author

Would you like a new file or should I add a test to test/simple/test-net-server-bind.js. This seems to be the only place the arguments to listen() are tested. Not sure what else to test except for the listen call not failing. Can't really test the actual size of the backlog.

Also see my comments on your comments.

@bnoordhuis
Copy link
Member

test/simple/test-net-server-bind.js is fine. The main thing to test for is that the patch doesn't introduce regressions in parsing .listen() arguments.

@erikdubbelboer
Copy link
Author

I have added some simple tests.

@bnoordhuis
Copy link
Member

Thanks Erik, merged in 3d69bbf.

@bnoordhuis bnoordhuis closed this Apr 18, 2012
richardlau pushed a commit to ibmruntimes/node that referenced this pull request Oct 6, 2015
@rvagg
2015-10-05, Version 4.1.2 (Stable) Release
820735d 
Notable changes

* http:
  - Fix out-of-order 'finish' event bug in pipelining that can abort
    execution, fixes DoS vulnerability CVE-2015-7384
    (Fedor Indutny) nodejs#3128
  - Account for pending response data instead of just the data on the
    current request to decide whether pause the socket or not
    (Fedor Indutny) nodejs#3128
* libuv: Upgraded from v1.7.4 to v1.7.5, see release notes for details
  (Saúl Ibarra Corretgé) nodejs#3010
  - A better rwlock implementation for all Windows versions
  - Improved AIX support
* v8:
  - Upgraded from v4.5.103.33 to v4.5.103.35 (Ali Ijaz Sheikh) nodejs#3117
  - Backported f782159 from v8's upstream to help speed up Promise
    introspection (Ben Noordhuis) nodejs#3130
  - Backported c281c15 from v8's upstream to add JSTypedArray length
    in post-mortem metadata (Julien Gilli) nodejs#3031

PR-URL: nodejs/node#3128
richardlau pushed a commit to ibmruntimes/node that referenced this pull request Oct 6, 2015
@rvagg
2015-10-05, Version 4.1.2 (Stable) Release
85df6ad 
Notable changes

* http:
  - Fix out-of-order 'finish' event bug in pipelining that can abort
    execution, fixes DoS vulnerability CVE-2015-7384
    (Fedor Indutny) nodejs#3128
  - Account for pending response data instead of just the data on the
    current request to decide whether pause the socket or not
    (Fedor Indutny) nodejs#3128
* libuv: Upgraded from v1.7.4 to v1.7.5, see release notes for details
  (Saúl Ibarra Corretgé) nodejs#3010
  - A better rwlock implementation for all Windows versions
  - Improved AIX support
* v8:
  - Upgraded from v4.5.103.33 to v4.5.103.35 (Ali Ijaz Sheikh) nodejs#3117
  - Backported f782159 from v8's upstream to help speed up Promise
    introspection (Ben Noordhuis) nodejs#3130
  - Backported c281c15 from v8's upstream to add JSTypedArray length
    in post-mortem metadata (Julien Gilli) nodejs#3031

PR-URL: nodejs/node#3128
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikdubbelboer @bnoordhuis