This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Fix armv6 detection #14193
Closed
Fix armv6 detection #14193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port 297cadb from io.js. Original commit message: The elf_platform suffix in /proc/cpuinfo moved to the model name field in Linux 3.8. Out-of-tree patch pending https://codereview.chromium.org/867713003/ Fixes: nodejs/node#283 PR-URL: nodejs/node#559 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Port 7d9d756 from io.js. Original commit message: VFPv3 is ARMv7-only, enabling it for ARMv6 is therefore always wrong. Mea culpa, I do believe I'm the original author of that change. Fixes: nodejs/node#283 PR-URL: nodejs/node#559 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Port c6cd460 from io.js. Original commit message: Remove the configure check, the flag was dropped in V8 3.28. PR-URL: nodejs/node#559 Reviewed-By: Fedor Indutny <fedor@indutny.com>
|
@joyent/node-coreteam Adding to the 0.12.2 milestone with P-2 because it would probably help a lot of Raspberry-PI users. These changes have been confirmed to work by a Raspberry-Pi user. |
|
/cc @joyent/node-coreteam I'll need a review before we can land that. It's been tested by @silverwind a while ago. Thank you! |
|
Here is the official patch from V8 team: https://github.com/v8/v8-git-mirror/blob/master/src/base/cpu.cc#L483-L499 I have created a pull request to solve this issue: #25625 |
|
Since armv6 works in Node > 1, I am going to assume this is no longer necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports nodejs/node#559 to joyent/node.