Fixes #3497 #3500
Fixes #3497 #3500
Conversation
| var address = function(a) { assert.deepEqual(a, expected); return true; }; | ||
| var count = 0; | ||
| for (var i in interfaces) { | ||
| var addr=interfaces[i].filter(filter).filter(address); |
There was a problem hiding this comment.
Also, I prefer an iterative approach over a functional one in tests. It's easier to debug when something goes wrong.
|
Thanks Ben. I made an unrelated change to fix a jslint warning, assume OK to include these in passing? Kev |
|
Kevin, can you rebase against the latest master? The PR doesn't apply cleanly right now. |
|
Updated and removed a bit of redundant code. Thanks. |
|
Kevin, it's still not applying. Can you do a |
|
Sorry Ben, looks like I created a false conflict swapping between machines. I have tried to correct in https://github.com/westboost/node/commit/74b60fab8fbc99f34d460b620ff193931f23ca01. If this is no good let's close this and I will clean up my fork and re-submit with some other test fixes I have. |
|
There's still a lot of noise. If you can either rebase or submit again, that'd be great. |
|
Can one of the admins verify this patch? |
|
It looks like the corresponding issue has since been closed. Closing. |
This iterates all interfaces to locate an IPv4 loopback rather than assuming fixed interface names.
Tested on OS X 10.6.8, CentOS 6.2 (64-bit) & Win XP SP2 (64-bit).