Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Allow the code to decide if it should use read or read2. #3674

Closed
wants to merge 1 commit into from
Closed

Allow the code to decide if it should use read or read2. #3674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/stream_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ Handle<Value> StreamWrap::ReadStart(const Arguments& args) {

UNWRAP(StreamWrap)

bool ipc_pipe = wrap->stream_->type == UV_NAMED_PIPE &&
((uv_pipe_t*)wrap->stream_)->ipc;
bool ipc_pipe = (args.Length()>0)?(args[0].IsTrue()):(wrap->stream_->type == UV_NAMED_PIPE &&
((uv_pipe_t*)wrap->stream_)->ipc);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One, this is unreadable. Two, what do you think happens when you call uv_read2() on a stream type that doesn't support it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can of course make it more readable & handle errors, too. But only if you are willing to pull it then ;)

int r;
if (ipc_pipe) {
r = uv_read2_start(wrap->stream_, OnAlloc, OnRead2);
Expand Down