Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

tls: Destroy socket when encrypted side closes #5170

Closed
wants to merge 1 commit into from

Commits on Mar 30, 2013

  1. tls: Destroy socket when encrypted side closes

    The v0.8 Stream.pipe() method automatically destroyed the destination
    stream whenever the src stream closed.  However, this caused a lot of
    problems, and was removed by popular demand.  (Many userland modules
    still have a no-op destroy() method just because of this.) It was also
    very hazardous because this would be done even if { end: false } was
    passed in the pipe options.
    
    In v0.10, we decided that the 'close' event and destroy() method are
    application-specific, and pipe() doesn't automatically call destroy().
    However, TLS actually depended (silently) on this behavior.  So, in this
    case, we should just go ahead and destroy the thing when close happens.
    
    Closes nodejs#5145
    isaacs committed Mar 30, 2013
    Copy the full SHA
    426de20 View commit details
    Browse the repository at this point in the history