This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Added support for options parameter in console.dir() #7754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this._stdout.write(util.inspect(object, { customInspect: false }) + '\n'); | ||
| Console.prototype.dir = function(object, options) { | ||
| if (util.isObject(options)) { | ||
| options.customInspect = false; |
There was a problem hiding this comment.
I think it should be using util._extend() here. Modifying user-supplied object is not really a good idea.
|
Generally looks good, but could you please take a look at https://github.com/joyent/node/blob/master/CONTRIBUTING.md and fix the commit log, and sign CLA? |
This features comes from the need of adding extra options when displaying the object using console.dir(). console.dir() accepts now a second parameter that is passed to util.inspect() in order to provide extra options to the output. These options are: depth, color and showHidden. More information about these options in util.inspect() documentation.
|
I signed CLA and changed the method to use util._extend() |
|
Thank you, landed with minor style fixes in 1cd48c7. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved issue: #5428. Now console.dir() accepts an optional parameter to define the maximum depth, colors and showHidden of the output.