Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Update README.md #8972

Closed
wants to merge 1 commit into from
Closed

Update README.md #8972

wants to merge 1 commit into from

Conversation

frankcash
Copy link

Extends a hyperlink to cover the whole line

Extends a hyperlink to cover the whole line
@frankcash
Copy link
Author

This has been really bothering me. Before only the second portion of the line was showing up as a hyperlink, after the whole line shows up as a hyper link.

I also think since freenode is the only linked IRC channel this is fine.

@sylvia43
Copy link

sylvia43 commented Jan 5, 2015

Bump. Useful addition.

@Legoben
Copy link

Legoben commented Jan 5, 2015

This has been needed for a while, glad someone got around to fixing it.

@sdaitzman
Copy link

This should definitely be fixed - it needs to look professional.

@tjhorner
Copy link

tjhorner commented Jan 6, 2015

👍 Good modification, make it consistent.

@steinomatic
Copy link

This fix greatly improves readability in my opinion

@dasilvacontin
Copy link

We could make AB testing on this to see if it really improves UX.

@rodrigoargumedo
Copy link

👍 Much needed update. Please merge it.

@geek geek self-assigned this Jan 16, 2015
@cjihrig
Copy link

cjihrig commented Jan 16, 2015

@geek LGTM

@csgregorian
Copy link

A great addition to this project.

@steinomatic
Copy link

Honestly this has been bugging me for a while now, I'm glad someone's finally doing something about it

@bryangarza
Copy link

Looks a lot better 👍

@sylvia43
Copy link

Is there any reason this hasn't been merged already?

@rodrigoargumedo
Copy link

Right now, they are reviewing it atm and then merge it.

Sent from my iPod

On Jan 15, 2015, at 8:49 PM, Shreyas notifications@github.com wrote:

Is there any reason this hasn't been merged already?


Reply to this email directly or view it on GitHub.

@piedoom
Copy link

piedoom commented Jan 16, 2015

good fix, makes things look much better

@pixelyunicorn
Copy link

This sounds like fun.

If this pull request actually gets merged, then @frankcash has tattoo this hash. 😉

@payam-g
Copy link

payam-g commented Jan 16, 2015

I agree, should be merged.

@zlassiter
Copy link

nice work

@lawrencelm
Copy link

great addition! it makes everything so much better

@sdaitzman
Copy link

I don't understand why this hasn't been merged yet...

@tjhorner
Copy link

@sdaitzman Yeah, me too.

@geek
Copy link
Member

geek commented Jan 19, 2015

Thanks, @frankcash landed in 404f0fb

@geek geek closed this Jan 19, 2015
@sylvia43
Copy link

@frankcash OMMGGGGGG IT HAPPENED :DDDDD YOU HAVE TO TATTOO THE HASH NOW

geek pushed a commit that referenced this pull request Jan 19, 2015
Extends a hyperlink to cover the whole line

PR-URL: #8972
Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
@tjhorner
Copy link

Do it @frankcash

@robbyoconnor
Copy link

Nice job @frankcash <3

@piedoom
Copy link

piedoom commented Jan 19, 2015

@frankcash better deliver

@pixelyunicorn
Copy link

Finally! Remember what you promised us, @frankcash! 💃

@sylvia43
Copy link

Out of respect for the only real dev language, /thread.

@jtmarmon
Copy link

jtmarmon commented Feb 1, 2015

sick @frankcash

jasnell pushed a commit to jasnell/node-joyent that referenced this pull request Mar 14, 2015
Extends a hyperlink to cover the whole line

PR-URL: nodejs#8972
Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.