-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Conversation
Extends a hyperlink to cover the whole line
This has been really bothering me. Before only the second portion of the line was showing up as a hyperlink, after the whole line shows up as a hyper link. I also think since freenode is the only linked IRC channel this is fine. |
Bump. Useful addition. |
This has been needed for a while, glad someone got around to fixing it. |
This should definitely be fixed - it needs to look professional. |
👍 Good modification, make it consistent. |
This fix greatly improves readability in my opinion |
We could make AB testing on this to see if it really improves UX. |
👍 Much needed update. Please merge it. |
@geek LGTM |
A great addition to this project. |
Honestly this has been bugging me for a while now, I'm glad someone's finally doing something about it |
Looks a lot better 👍 |
Is there any reason this hasn't been merged already? |
Right now, they are reviewing it atm and then merge it. Sent from my iPod On Jan 15, 2015, at 8:49 PM, Shreyas notifications@github.com wrote:
|
good fix, makes things look much better |
This sounds like fun. If this pull request actually gets merged, then @frankcash has tattoo this hash. 😉 |
I agree, should be merged. |
nice work |
great addition! it makes everything so much better |
I don't understand why this hasn't been merged yet... |
@sdaitzman Yeah, me too. |
Thanks, @frankcash landed in 404f0fb |
@frankcash OMMGGGGGG IT HAPPENED :DDDDD YOU HAVE TO TATTOO THE HASH NOW |
Extends a hyperlink to cover the whole line PR-URL: #8972 Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
Do it @frankcash |
Nice job @frankcash <3 |
@frankcash better deliver |
Finally! Remember what you promised us, @frankcash! 💃 |
Out of respect for the only real dev language, /thread. |
sick @frankcash |
Extends a hyperlink to cover the whole line PR-URL: nodejs#8972 Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
Extends a hyperlink to cover the whole line