Skip to content

Commit

Permalink
deps: V8: workaround for MSVC 14.20 optimizer bug
Browse files Browse the repository at this point in the history
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
refack authored and nodejs-ci committed Jul 15, 2019
1 parent 183c3b4 commit 94bb46f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.7',
'v8_embedder_string': '-node.8',

##### V8 defaults for Node.js #####

Expand Down
9 changes: 9 additions & 0 deletions deps/v8/src/builtins/setup-builtins-internal.cc
Expand Up @@ -276,6 +276,10 @@ Code GenerateBytecodeHandler(Isolate* isolate, int builtin_index,

} // namespace

#if _MSC_VER == 1920
#pragma optimize( "", off )
#endif

// static
void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) {
Builtins* builtins = isolate->builtins();
Expand Down Expand Up @@ -353,5 +357,10 @@ void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) {
builtins->MarkInitialized();
}

#if _MSC_VER == 1920
#pragma optimize( "", on )
#endif


} // namespace internal
} // namespace v8

0 comments on commit 94bb46f

Please sign in to comment.