fix(http2): check content-length, fix sending RST #51393
Annotations
5 errors
test-macOS:
test/parallel/test-http2-client-destroy.js#L120
--- stdout ---
Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
at mustCall (/Users/runner/work/node/node/test/common/index.js:424:10)
at Proxy.expectsError (/Users/runner/work/node/node/test/common/index.js:709:10)
at Http2Server.<anonymous> (/Users/runner/work/node/node/test/parallel/test-http2-client-destroy.js:120:30)
at Http2Server.<anonymous> (/Users/runner/work/node/node/test/common/index.js:466:15)
at Object.onceWrapper (node:events:634:28)
at Http2Server.emit (node:events:520:28)
at emitListeningNT (node:net:1932:10)
at process.processTicksAndRejections (node:internal/process/task_queues:81:21)
Command: out/Release/node --expose-internals --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-http2-client-destroy.js
|
test-macOS:
test/parallel/test-http2-server-shutdown-options-errors.js#L62
--- stdout ---
Mismatched noop function calls. Expected exactly 1, actual 0.
at Proxy.mustCall (/Users/runner/work/node/node/test/common/index.js:424:10)
at Http2Server.<anonymous> (/Users/runner/work/node/node/test/parallel/test-http2-server-shutdown-options-errors.js:62:30)
at Http2Server.<anonymous> (/Users/runner/work/node/node/test/common/index.js:466:15)
at Object.onceWrapper (node:events:634:28)
at Http2Server.emit (node:events:520:28)
at emitListeningNT (node:net:1932:10)
at process.processTicksAndRejections (node:internal/process/task_queues:81:21)
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-http2-server-shutdown-options-errors.js
|
test-macOS:
test/parallel/test-http2-server-socket-destroy.js#L1
--- stderr ---
node:assert:644
throw err;
^
AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected
Comparison {
+ code: 'ECONNRESET',
+ message: 'read ECONNRESET',
- code: 'ERR_HTTP2_STREAM_ERROR',
- message: 'Stream closed with error code NGHTTP2_INTERNAL_ERROR',
name: 'Error'
}
at ClientHttp2Stream.<anonymous> (/Users/runner/work/node/node/test/common/index.js:719:12)
at ClientHttp2Stream.<anonymous> (/Users/runner/work/node/node/test/common/index.js:466:15)
at ClientHttp2Stream.emit (node:events:532:35)
at emitErrorNT (node:internal/streams/destroy:170:8)
at emitErrorCloseNT (node:internal/streams/destroy:129:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: Error: read ECONNRESET
at TCP.onStreamRead (node:internal/stream_base_commons:218:20) {
errno: -54,
code: 'ECONNRESET',
syscall: 'read'
},
expected: {
name: 'Error',
code: 'ERR_HTTP2_STREAM_ERROR',
message: 'Stream closed with error code NGHTTP2_INTERNAL_ERROR'
},
operator: 'throws'
}
Node.js v23.0.0-pre
Command: out/Release/node --expose-internals --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-http2-server-socket-destroy.js
|
test-macOS:
test/parallel/test-http2-server-stream-session-destroy.js#L1
--- stderr ---
node:assert:173
throw err;
^
AssertionError [ERR_ASSERTION]: function should not have been called at /Users/runner/work/node/node/test/parallel/test-http2-server-stream-session-destroy.js:56
at ClientHttp2Stream.mustNotCall (/Users/runner/work/node/node/test/common/index.js:544:12)
at ClientHttp2Stream.emit (node:events:520:28)
at endReadableNT (node:internal/streams/readable:1696:12)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
generatedMessage: false,
code: 'ERR_ASSERTION',
actual: undefined,
expected: undefined,
operator: 'fail'
}
Node.js v23.0.0-pre
Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-http2-server-stream-session-destroy.js
|
test-macOS
Process completed with exit code 2.
|