Skip to content

Commit

Permalink
test: enable setuid/setgid test
Browse files Browse the repository at this point in the history
Refactor test for situations where it was expected to fail.
Move from disabled directory to parallel.

PR-URL: #12403
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  • Loading branch information
Trott authored and evanlucas committed May 2, 2017
1 parent 4570d98 commit 0f290f2
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 23 deletions.
23 changes: 0 additions & 23 deletions test/disabled/test-setuidgid.js

This file was deleted.

47 changes: 47 additions & 0 deletions test/parallel/test-process-setuid-setgid.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
'use strict';
const common = require('../common');

const assert = require('assert');

if (common.isWindows) {
// uid/gid functions are POSIX only
assert.strictEqual(process.getuid, undefined);
assert.strictEqual(process.setuid, undefined);
assert.strictEqual(process.getgid, undefined);
assert.strictEqual(process.setgid, undefined);
return;
}

assert.throws(() => {
process.setuid('fhqwhgadshgnsdhjsdbkhsdabkfabkveybvf');
}, /^Error: setuid user id does not exist$/);

// If we're not running as super user...
if (process.getuid() !== 0) {
assert.doesNotThrow(() => {
process.getgid();
process.getuid();
});

assert.throws(
() => { process.setgid('nobody'); },
/^Error: (EPERM, .+|setgid group id does not exist)$/
);

assert.throws(
() => { process.setuid('nobody'); },
/^Error: EPERM, /
);
return;
}

// If we are running as super user...
const oldgid = process.getgid();
process.setgid('nobody');
const newgid = process.getgid();
assert.notStrictEqual(newgid, oldgid);

const olduid = process.getuid();
process.setuid('nobody');
const newuid = process.getuid();
assert.notStrictEqual(newuid, olduid);

0 comments on commit 0f290f2

Please sign in to comment.