Skip to content

Commit

Permalink
test: remove unnecessary eslint-disable comments
Browse files Browse the repository at this point in the history
PR-URL: #25119
Refs: https://eslint.org/docs/user-guide/command-line-interface#--report-unused-disable-directives
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
Trott authored and MylesBorins committed Dec 26, 2018
1 parent 6a690ee commit 175f7b6
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion test/common/wpt.js
@@ -1,4 +1,3 @@
/* eslint-disable node-core/required-modules */
'use strict';

const assert = require('assert');
Expand Down
1 change: 0 additions & 1 deletion test/js-native-api/test_general/testNapiRun.js
Expand Up @@ -4,7 +4,6 @@ const common = require('../../common');
const assert = require('assert');

// `addon` is referenced through the eval expression in testFile
// eslint-disable-next-line no-unused-vars
const addon = require(`./build/${common.buildType}/test_general`);

const testCase = '(41.92 + 0.08);';
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-assert-deep.js
Expand Up @@ -42,7 +42,7 @@ function re(literals, ...values) {
// That is why we discourage using deepEqual in our own tests.

// Turn off no-restricted-properties because we are testing deepEqual!
/* eslint-disable no-restricted-properties, prefer-common-expectserror */
/* eslint-disable no-restricted-properties */

const arr = new Uint8Array([120, 121, 122, 10]);
const buf = Buffer.from(arr);
Expand Down
3 changes: 0 additions & 3 deletions test/parallel/test-assert.js
Expand Up @@ -21,8 +21,6 @@

'use strict';

/* eslint-disable node-core/prefer-common-expectserror */

const common = require('../common');
const assert = require('assert');
const { inspect } = require('util');
Expand Down Expand Up @@ -662,7 +660,6 @@ common.expectsError(
const tmp = fs.close;
fs.close = common.mustCall(tmp, 1);
function throwErr() {
// eslint-disable-next-line prefer-assert-methods
assert(
(Buffer.from('test') instanceof Error)
);
Expand Down

0 comments on commit 175f7b6

Please sign in to comment.