Skip to content

Commit

Permalink
build: run linter before running tests
Browse files Browse the repository at this point in the history
PR-URL: #16284
Fixes: https://github.com/node/issues/16283
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
  • Loading branch information
joyeecheung committed Oct 29, 2017
1 parent a70ef36 commit 2875459
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion Makefile
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -213,15 +213,26 @@ test: all
$(MAKE) build-addons $(MAKE) build-addons
$(MAKE) build-addons-napi $(MAKE) build-addons-napi
$(MAKE) doc-only $(MAKE) doc-only
$(MAKE) lint
$(MAKE) cctest $(MAKE) cctest
$(PYTHON) tools/test.py --mode=release -J \ $(PYTHON) tools/test.py --mode=release -J \
$(CI_ASYNC_HOOKS) \ $(CI_ASYNC_HOOKS) \
$(CI_JS_SUITES) \ $(CI_JS_SUITES) \
$(CI_NATIVE_SUITES) \ $(CI_NATIVE_SUITES) \
doctool known_issues doctool known_issues
$(MAKE) lint
endif endif


# For a quick test, does not run linter or build doc
test-only: all
$(MAKE) build-addons
$(MAKE) build-addons-napi
$(MAKE) cctest
$(PYTHON) tools/test.py --mode=release -J \
$(CI_ASYNC_HOOKS) \
$(CI_JS_SUITES) \
$(CI_NATIVE_SUITES) \
known_issues

test-cov: all test-cov: all
$(MAKE) build-addons $(MAKE) build-addons
$(MAKE) build-addons-napi $(MAKE) build-addons-napi
Expand Down Expand Up @@ -1107,6 +1118,7 @@ endif
test-gc \ test-gc \
test-gc-clean \ test-gc-clean \
test-hash-seed \ test-hash-seed \
test-only \
test-v8 \ test-v8 \
test-v8-all \ test-v8-all \
test-v8-benchmarks \ test-v8-benchmarks \
Expand Down

0 comments on commit 2875459

Please sign in to comment.