Skip to content

Commit

Permalink
src: remove unused misc variable
Browse files Browse the repository at this point in the history
This commit removes the unused 'misc' variable from one of the
NodeMainInstance constructors.

Another option could be to add a default argument to
SetIsolateMiscHandlers but I'd like to hear what others think about that
first.

PR-URL: #33417
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
danbev authored and targos committed Jun 2, 2020
1 parent 7fd0519 commit 308be6c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/node_main_instance.cc
Expand Up @@ -39,8 +39,7 @@ NodeMainInstance::NodeMainInstance(Isolate* isolate,
isolate_data_ =
std::make_unique<IsolateData>(isolate_, event_loop, platform, nullptr);

IsolateSettings misc;
SetIsolateMiscHandlers(isolate_, misc);
SetIsolateMiscHandlers(isolate_, {});
}

std::unique_ptr<NodeMainInstance> NodeMainInstance::Create(
Expand Down

0 comments on commit 308be6c

Please sign in to comment.