Skip to content

Commit

Permalink
util: use let instead of var for util/inspect.js
Browse files Browse the repository at this point in the history
PR-URL: #30399
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
lmammino authored and gireeshpunathil committed Nov 26, 2019
1 parent ecfebee commit 3f59704
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions lib/internal/util/inspect.js
Expand Up @@ -1165,7 +1165,7 @@ function formatPrimitive(fn, value, ctx) {

function formatNamespaceObject(ctx, value, recurseTimes, keys) {
const output = new Array(keys.length);
for (var i = 0; i < keys.length; i++) {
for (let i = 0; i < keys.length; i++) {
try {
output[i] = formatProperty(ctx, value, recurseTimes, keys[i],
kObjectType);
Expand Down Expand Up @@ -1253,7 +1253,7 @@ function formatArray(ctx, value, recurseTimes) {

const remaining = valLen - len;
const output = [];
for (var i = 0; i < len; i++) {
for (let i = 0; i < len; i++) {
// Special handle sparse arrays.
if (!ObjectPrototypeHasOwnProperty(value, i)) {
return formatSpecialArray(ctx, value, recurseTimes, len, output, i);
Expand Down Expand Up @@ -1329,7 +1329,7 @@ function formatSetIterInner(ctx, recurseTimes, entries, state) {
const maxLength = MathMin(maxArrayLength, entries.length);
let output = new Array(maxLength);
ctx.indentationLvl += 2;
for (var i = 0; i < maxLength; i++) {
for (let i = 0; i < maxLength; i++) {
output[i] = formatValue(ctx, entries[i], recurseTimes);
}
ctx.indentationLvl -= 2;
Expand Down Expand Up @@ -1497,7 +1497,7 @@ function isBelowBreakLength(ctx, output, start, base) {
let totalLength = output.length + start;
if (totalLength + output.length > ctx.breakLength)
return false;
for (var i = 0; i < output.length; i++) {
for (let i = 0; i < output.length; i++) {
if (ctx.colors) {
totalLength += removeColors(output[i]).length;
} else {
Expand Down Expand Up @@ -1618,7 +1618,7 @@ function formatWithOptionsInternal(inspectOptions, ...args) {
let tempStr;
let lastPos = 0;

for (var i = 0; i < first.length - 1; i++) {
for (let i = 0; i < first.length - 1; i++) {
if (first.charCodeAt(i) === 37) { // '%'
const nextChar = first.charCodeAt(++i);
if (a + 1 !== args.length) {
Expand Down

0 comments on commit 3f59704

Please sign in to comment.