Skip to content

Commit

Permalink
test: increase timeout in vm-timeout-escape-queuemicrotask
Browse files Browse the repository at this point in the history
It looks like under high load the loop isn't even started and therefore
successfully finishes without 'escaping'. After increasing the timeout
during parallel run of the test failure rate decreased from 15/1000 to
0/1000.

PR-URL: #31966
Refs: #25529
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
lundibundi authored and codebytere committed Feb 27, 2020
1 parent 6adbfac commit 49c959d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/known_issues/test-vm-timeout-escape-queuemicrotask.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ const NS_PER_MS = 1000000n;

const hrtime = process.hrtime.bigint;

const loopDuration = common.platformTimeout(100n);
const timeout = common.platformTimeout(10);
const loopDuration = common.platformTimeout(1000n);
const timeout = common.platformTimeout(100);

function loop() {
const start = hrtime();
Expand Down

0 comments on commit 49c959d

Please sign in to comment.