Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky known_issues/test-vm-timeout-escape-queuemicrotask #25529

Closed
joyeecheung opened this issue Jan 16, 2019 · 6 comments
Closed

Investigate flaky known_issues/test-vm-timeout-escape-queuemicrotask #25529

joyeecheung opened this issue Jan 16, 2019 · 6 comments
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.

Comments

@joyeecheung
Copy link
Member

Refs: nodejs/reliability#20

Reason known_issues/test-vm-timeout-escape-queuemicrotask
Type JS_TEST_FAILURE
Failed PR 25 (#25441, #24951, #25463, #22712, #25466, #25480, #25430, #25488, #25415, #25479, #25364, #25412, #25472, #25490, #25443, #25502, #25481, #25381, #25429, #25008, #24819, #25507, #25508, #25473, #25455)
Appeared test-packetnet-centos7-arm64-1, test-packetnet-ubuntu1604-arm64-2, test-packetnet-ubuntu1604-arm64-1, test-joyent-smartos17-x64-2
First CI https://ci.nodejs.org/job/node-test-pull-request/20074/
Last CI https://ci.nodejs.org/job/node-test-pull-request/20137/
Example 
not ok 2345 known_issues/test-vm-timeout-escape-queuemicrotask
  ---
  duration_ms: 0.333
  severity: fail
  stack: |-
    (node:38468) ExperimentalWarning: queueMicrotask() is experimental.
  ...
@gireeshpunathil
Copy link
Member

#25503 might have solved this?

@joyeecheung
Copy link
Member Author

@gireeshpunathil The last failure appeared in https://ci.nodejs.org/job/node-test-pull-request/20137/ so looks like it's been fixed but I'd suggest we observe for a couple days before closing this.

@joyeecheung joyeecheung added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jan 16, 2019
@joyeecheung joyeecheung mentioned this issue Mar 22, 2019
Closed
@joyeecheung
Copy link
Member Author

joyeecheung commented Mar 22, 2019 •
edited

This showed up in 3 out of 58 recent CI runs: nodejs/reliability#21

@sam-github sam-github added arm Issues and PRs related to the ARM platform. smartos Issues and PRs related to the SmartOS platform. labels Jun 7, 2019
@gireeshpunathil
Copy link
Member

seen again in arm: https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=0,label=pi2-docker/4569/console

@gireeshpunathil
Copy link
Member

and in:

@lundibundi lundibundi mentioned this issue Feb 26, 2020
Closed
2 tasks
Trott pushed a commit that referenced this issue Feb 27, 2020
@lundibundi @Trott
test: increase timeout in vm-timeout-escape-queuemicrotask
468bfd3 
It looks like under high load the loop isn't even started and therefore
successfully finishes without 'escaping'. After increasing the timeout
during parallel run of the test failure rate decreased from 15/1000 to
0/1000.

PR-URL: #31966
Refs: #25529
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Feb 27, 2020

Hopefully fixed (or at least fixed-ish) by 468bfd3

@Trott Trott closed this as completed Feb 27, 2020
codebytere pushed a commit that referenced this issue Feb 27, 2020
@lundibundi @codebytere
test: increase timeout in vm-timeout-escape-queuemicrotask
49c959d 
It looks like under high load the loop isn't even started and therefore
successfully finishes without 'escaping'. After increasing the timeout
during parallel run of the test failure rate decreased from 15/1000 to
0/1000.

PR-URL: #31966
Refs: #25529
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this issue Mar 15, 2020
@lundibundi @codebytere
test: increase timeout in vm-timeout-escape-queuemicrotask
2900807 
It looks like under high load the loop isn't even started and therefore
successfully finishes without 'escaping'. After increasing the timeout
during parallel run of the test failure rate decreased from 15/1000 to
0/1000.

PR-URL: #31966
Refs: #25529
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this issue Mar 17, 2020
@lundibundi @codebytere
test: increase timeout in vm-timeout-escape-queuemicrotask
3adcac0 
It looks like under high load the loop isn't even started and therefore
successfully finishes without 'escaping'. After increasing the timeout
during parallel run of the test failure rate decreased from 15/1000 to
0/1000.

PR-URL: #31966
Refs: #25529
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this issue Mar 30, 2020
@lundibundi @codebytere
test: increase timeout in vm-timeout-escape-queuemicrotask
086e14d 
It looks like under high load the loop isn't even started and therefore
successfully finishes without 'escaping'. After increasing the timeout
during parallel run of the test failure rate decreased from 15/1000 to
0/1000.

PR-URL: #31966
Refs: #25529
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sam-github @Trott @joyeecheung @gireeshpunathil