Skip to content

Commit

Permalink
test: increase coverage for stream
Browse files Browse the repository at this point in the history
1. test addAbortSignal with invalid signal
Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L17

2. test addAbortSignal with invalid stream
Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L28

3. test addAbortSignalNoValidate with invalid signal
Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L34

4. test addAbortSignalNoValidate with aborted signal
Refs:  https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L40

5. test Readable.from with invalid args
Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/from.js.html#L31

PR-URL: #36538
Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L40
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
  • Loading branch information
Lxxyx authored and mhdawson committed Dec 21, 2020
1 parent aadb0bd commit 4d22dd3
Show file tree
Hide file tree
Showing 3 changed files with 49 additions and 1 deletion.
8 changes: 7 additions & 1 deletion test/parallel/test-readable-from.js
Expand Up @@ -3,7 +3,13 @@
const { mustCall } = require('../common');
const { once } = require('events');
const { Readable } = require('stream');
const { strictEqual } = require('assert');
const { strictEqual, throws } = require('assert');

{
throws(() => {
Readable.from(null);
}, /ERR_INVALID_ARG_TYPE/);
}

async function toReadableBasicSupport() {
async function* generate() {
Expand Down
27 changes: 27 additions & 0 deletions test/parallel/test-stream-add-abort-signal.js
@@ -0,0 +1,27 @@
// Flags: --expose-internals
'use strict';

require('../common');
const assert = require('assert');
const { addAbortSignal, Readable } = require('stream');
const {
addAbortSignalNoValidate,
} = require('internal/streams/add-abort-signal');

{
assert.throws(() => {
addAbortSignal('INVALID_SIGNAL');
}, /ERR_INVALID_ARG_TYPE/);

const ac = new AbortController();
assert.throws(() => {
addAbortSignal(ac.signal, 'INVALID_STREAM');
}, /ERR_INVALID_ARG_TYPE/);
}

{
const r = new Readable({
read: () => {},
});
assert.deepStrictEqual(r, addAbortSignalNoValidate('INVALID_SIGNAL', r));
}
15 changes: 15 additions & 0 deletions test/parallel/test-stream-writable-destroy.js
Expand Up @@ -446,3 +446,18 @@ const assert = require('assert');
write.write('asd');
ac.abort();
}

{
const ac = new AbortController();
ac.abort();

const write = new Writable({
signal: ac.signal,
write(chunk, enc, cb) { cb(); }
});

write.on('error', common.mustCall((e) => {
assert.strictEqual(e.name, 'AbortError');
assert.strictEqual(write.destroyed, true);
}));
}

0 comments on commit 4d22dd3

Please sign in to comment.