Skip to content

Commit

Permalink
src: deprecate undocumented variables
Browse files Browse the repository at this point in the history
The `root` and `GLOBAL` were never documented.

PR-URL: #1838
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information
JacksonTian authored and bnoordhuis committed Feb 10, 2016
1 parent b212be0 commit 4e46931
Showing 1 changed file with 21 additions and 2 deletions.
23 changes: 21 additions & 2 deletions src/node.js
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,27 @@
startup.globalVariables = function() {
global.process = process;
global.global = global;
global.GLOBAL = global;
global.root = global;
const util = NativeModule.require('util');

// Deprecate GLOBAL and root
['GLOBAL', 'root'].forEach(function(name) {
// getter
const get = util.deprecate(function() {
return this;
}, `'${name}' is deprecated, use 'global'`);
// setter
const set = util.deprecate(function(value) {
Object.defineProperty(this, name, {
configurable: true,
writable: true,
enumerable: true,
value: value
});
}, `'${name}' is deprecated, use 'global'`);
// define property
Object.defineProperty(global, name, { get, set, configurable: true });
});

global.Buffer = NativeModule.require('buffer').Buffer;
process.domain = null;
process._exiting = false;
Expand Down

0 comments on commit 4e46931

Please sign in to comment.