Skip to content

Commit

Permalink
src: fix inconsistency in extern declaration
Browse files Browse the repository at this point in the history
NodeCounterProvider is declared as extern but defined as EXTERN_C.
This confuses clang-cl.

PR-URL: #20436
Refs: #19630
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information
hashseed authored and MylesBorins committed May 9, 2018
1 parent 70b2e16 commit 54f3065
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/node_win32_perfctr_provider.cc
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ PPERF_COUNTERSET_INSTANCE perfctr_instance;
namespace node {


EXTERN_C DECLSPEC_SELECTANY HANDLE NodeCounterProvider = nullptr;
HANDLE NodeCounterProvider = nullptr;

void InitPerfCountersWin32() {
ULONG status;
Expand Down

0 comments on commit 54f3065

Please sign in to comment.