Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix inconsistency in extern declaration #20436

Closed
wants to merge 1 commit into from
Closed

src: fix inconsistency in extern declaration #20436

wants to merge 1 commit into from

Conversation

hashseed
Copy link
Member

NodeCounterProvider is declared as extern but defined as EXTERN_C.
This confuses clang-cl.

Refs: #19630

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@hashseed
src: fix inconsistency in extern declaration
3b8e928 
NodeCounterProvider is declared as extern but defined as EXTERN_C.
This confuses clang-cl.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. windows Issues and PRs related to the Windows platform. labels Apr 30, 2018
@hashseed
Copy link
Member Author

CI job: https://ci.nodejs.org/job/node-test-pull-request/14603/

bnoordhuis
bnoordhuis approved these changes Apr 30, 2018
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back-linking to v8#67 for posterity.

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 30, 2018
@addaleax
Copy link
Member

addaleax commented May 5, 2018

Landed in 4546ad2

@addaleax addaleax closed this May 5, 2018
addaleax pushed a commit that referenced this pull request May 5, 2018
@hashseed @addaleax
src: fix inconsistency in extern declaration
4546ad2 
NodeCounterProvider is declared as extern but defined as EXTERN_C.
This confuses clang-cl.

PR-URL: #20436
Refs: #19630
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@hashseed @MylesBorins
src: fix inconsistency in extern declaration
ae33fa3 
NodeCounterProvider is declared as extern but defined as EXTERN_C.
This confuses clang-cl.

PR-URL: #20436
Refs: #19630
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@hashseed @MylesBorins
src: fix inconsistency in extern declaration
5dc293d 
NodeCounterProvider is declared as extern but defined as EXTERN_C.
This confuses clang-cl.

PR-URL: #20436
Refs: #19630
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request May 9, 2018
@hashseed @MylesBorins
src: fix inconsistency in extern declaration
54f3065 
NodeCounterProvider is declared as extern but defined as EXTERN_C.
This confuses clang-cl.

PR-URL: #20436
Refs: #19630
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@hashseed hashseed deleted the fixclangcl-node branch July 13, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@addaleax addaleax addaleax approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@hashseed @addaleax @refack @bnoordhuis @TimothyGu @cjihrig @tniessen @BridgeAR @nodejs-github-bot