Skip to content

Commit

Permalink
test: improve assertions in pummel/test-timers
Browse files Browse the repository at this point in the history
* Timers should not fire early. Check for that.
* Allow the wiggle-room to increase on subsequent iterations of
  intervals.

PR-URL: #35216
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
  • Loading branch information
Trott authored and addaleax committed Sep 22, 2020
1 parent 1018e52 commit 5a6bdd0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/pummel/test-timers.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const WINDOW = 200; // Why does this need to be so big?
assert.ok(diff > 0);
console.error(`diff: ${diff}`);

assert.strictEqual(1000 - WINDOW < diff && diff < 1000 + WINDOW, true);
assert.ok(1000 <= diff && diff < 1000 + WINDOW);
}), 1000);
}

Expand All @@ -61,7 +61,7 @@ const WINDOW = 200; // Why does this need to be so big?

const t = interval_count * 1000;

assert.ok(t - WINDOW < diff && diff < t + WINDOW, `t: ${t}`);
assert.ok(t <= diff && diff < t + (WINDOW * interval_count));

assert.ok(interval_count <= 3, `interval_count: ${interval_count}`);
if (interval_count === 3)
Expand Down

0 comments on commit 5a6bdd0

Please sign in to comment.