-
Notifications
You must be signed in to change notification settings - Fork 28.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
lib/constants.js was incorrectly copying the constants from the binding, by copying from `contants.os.errors` instead of `constants.os.errno`. PR-URL: #9349 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- Loading branch information
Showing
2 changed files
with
22 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,26 @@ | ||
'use strict'; | ||
|
||
require('../common'); | ||
const constants = process.binding('constants'); | ||
const binding = process.binding('constants'); | ||
const constants = require('constants'); | ||
const assert = require('assert'); | ||
|
||
assert.ok(constants); | ||
assert.ok(constants.os); | ||
assert.ok(constants.os.signals); | ||
assert.ok(constants.os.errno); | ||
assert.ok(constants.fs); | ||
assert.ok(constants.crypto); | ||
assert.ok(binding); | ||
assert.ok(binding.os); | ||
assert.ok(binding.os.signals); | ||
assert.ok(binding.os.errno); | ||
assert.ok(binding.fs); | ||
assert.ok(binding.crypto); | ||
|
||
['os', 'fs', 'crypto'].forEach((l) => { | ||
Object.keys(binding[l]).forEach((k) => { | ||
if (typeof binding[l][k] === 'object') { // errno and signals | ||
Object.keys(binding[l][k]).forEach((j) => { | ||
assert.strictEqual(binding[l][k][j], constants[j]); | ||
}); | ||
} | ||
if (l !== 'os') { // top level os constant isn't currently copied | ||
assert.strictEqual(binding[l][k], constants[k]); | ||
} | ||
}); | ||
}); |