Permalink
Browse files

constants: errors -> errno

lib/constants.js was incorrectly copying the constants from the
binding, by copying from `contants.os.errors` instead of
`constants.os.errno`.

PR-URL: #9349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information...
bengl authored and addaleax committed Oct 28, 2016
1 parent 74c3283 commit 5c9aa1848404084a7c2398348a719d95c6048004
Showing with 22 additions and 8 deletions.
  1. +1 −1 lib/constants.js
  2. +21 −7 test/parallel/test-constants.js
View
@@ -5,7 +5,7 @@
// are most relevant.
const constants = process.binding('constants');
Object.assign(exports,
constants.os.errors,
constants.os.errno,
constants.os.signals,
constants.fs,
constants.crypto);
@@ -1,12 +1,26 @@
'use strict';
require('../common');
const constants = process.binding('constants');
const binding = process.binding('constants');
const constants = require('constants');
const assert = require('assert');
assert.ok(constants);
assert.ok(constants.os);
assert.ok(constants.os.signals);
assert.ok(constants.os.errno);
assert.ok(constants.fs);
assert.ok(constants.crypto);
assert.ok(binding);
assert.ok(binding.os);
assert.ok(binding.os.signals);
assert.ok(binding.os.errno);
assert.ok(binding.fs);
assert.ok(binding.crypto);
['os', 'fs', 'crypto'].forEach((l) => {
Object.keys(binding[l]).forEach((k) => {
if (typeof binding[l][k] === 'object') { // errno and signals
Object.keys(binding[l][k]).forEach((j) => {
assert.strictEqual(binding[l][k][j], constants[j]);
});
}
if (l !== 'os') { // top level os constant isn't currently copied
assert.strictEqual(binding[l][k], constants[k]);
}
});
});

0 comments on commit 5c9aa18

Please sign in to comment.