Skip to content

Commit

Permalink
process: wait for 'exit' before printing result
Browse files Browse the repository at this point in the history
Co-authored-by: Vinícius Lourenço <contact@viniciusl.com.br>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
H4ad and aduh95 committed Mar 21, 2024
1 parent c714cda commit 5d327ca
Show file tree
Hide file tree
Showing 2 changed files with 66 additions and 4 deletions.
5 changes: 4 additions & 1 deletion lib/internal/process/execution.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,10 @@ function evalScript(name, body, breakFirstLine, print, shouldLoadESM = false) {
});
if (print) {
const { log } = require('internal/console/global');
log(result);

process.on('exit', () => {
log(result);
});
}

if (origModule !== undefined)
Expand Down
65 changes: 62 additions & 3 deletions test/parallel/test-cli-print-promise.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('--print with a promise', { concurrency: true }, () => {
code: 0,
signal: null,
stderr: '',
stdout: 'Promise { <pending> }\n',
stdout: 'Promise { 42 }\n',
});
});

Expand All @@ -50,7 +50,7 @@ describe('--print with a promise', { concurrency: true }, () => {
it('should output something if process exits before promise settles', async () => {
const result = await spawnPromisified(execPath, [
'--print',
'setTimeout(process.exit,100, 0);timers.promises.setTimeout(200)',
'setTimeout(process.exit, 100, 0);timers.promises.setTimeout(200)',
]);

assert.deepStrictEqual(result, {
Expand All @@ -61,6 +61,20 @@ describe('--print with a promise', { concurrency: true }, () => {
});
});

it('should respect exit code when process exits before promise settles', async () => {
const result = await spawnPromisified(execPath, [
'--print',
'setTimeout(process.exit, 100, 42);timers.promises.setTimeout(200)',
]);

assert.deepStrictEqual(result, {
code: 42,
signal: null,
stderr: '',
stdout: 'Promise { <pending> }\n',
});
});

it('should handle rejected promises', async () => {
const result = await spawnPromisified(execPath, [
'--unhandled-rejections=none',
Expand All @@ -87,7 +101,52 @@ describe('--print with a promise', { concurrency: true }, () => {
code: 0,
signal: null,
stderr: '',
stdout: 'Promise { <pending> }\n',
stdout: 'Promise { <rejected> 1 }\n',
});
});

it('should handle thenable that resolves', async () => {
const result = await spawnPromisified(execPath, [
'--unhandled-rejections=none',
'--print',
'({ then(r) { r(42) } })',
]);

assert.deepStrictEqual(result, {
code: 0,
signal: null,
stderr: '',
stdout: '{ then: [Function: then] }\n',
});
});

it('should handle thenable that rejects', async () => {
const result = await spawnPromisified(execPath, [
'--unhandled-rejections=none',
'--print',
'({ then(_, r) { r(42) } })',
]);

assert.deepStrictEqual(result, {
code: 0,
signal: null,
stderr: '',
stdout: '{ then: [Function: then] }\n',
});
});

it('should handle Promise.prototype', async () => {
const result = await spawnPromisified(execPath, [
'--unhandled-rejections=none',
'--print',
'Promise.prototype',
]);

assert.deepStrictEqual(result, {
code: 0,
signal: null,
stderr: '',
stdout: 'Object [Promise] {}\n',
});
});
});

0 comments on commit 5d327ca

Please sign in to comment.