benchmark: cover more nextTick() code

The benchmarks for `process.nextTick()` do not cover the `default` case in the internal code's `switch` statement where the callback receives more than 3 arguments. Modify two of the benchmarks to include this condition.
nodejs · Aug 9, 2017 · 64e1f00 · 64e1f00
1 parent aa07e87
commit 64e1f00
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 4 deletions.
diff --git a/benchmark/process/next-tick-breadth-args.js b/benchmark/process/next-tick-breadth-args.js
@@ -24,10 +24,17 @@ function main(conf) {
     if (n === N)
       bench.end(n / 1e6);
   }
+  function cb4(arg1, arg2, arg3, arg4) {
+    n++;
+    if (n === N)
+      bench.end(n / 1e6);
+  }
 
   bench.start();
   for (var i = 0; i < N; i++) {
-    if (i % 3 === 0)
+    if (i % 4 === 0)
+      process.nextTick(cb4, 3.14, 1024, true, false);
+    else if (i % 3 === 0)
       process.nextTick(cb3, 512, true, null);
     else if (i % 2 === 0)
       process.nextTick(cb2, false, 5.1);

diff --git a/benchmark/process/next-tick-depth-args.js b/benchmark/process/next-tick-depth-args.js
@@ -10,9 +10,24 @@ process.maxTickDepth = Infinity;
 function main(conf) {
   var n = +conf.millions * 1e6;
 
+  function cb4(arg1, arg2, arg3, arg4) {
+    if (--n) {
+      if (n % 4 === 0)
+        process.nextTick(cb4, 3.14, 1024, true, false);
+      else if (n % 3 === 0)
+        process.nextTick(cb3, 512, true, null);
+      else if (n % 2 === 0)
+        process.nextTick(cb2, false, 5.1);
+      else
+        process.nextTick(cb1, 0);
+    } else
+      bench.end(+conf.millions);
+  }
   function cb3(arg1, arg2, arg3) {
     if (--n) {
-      if (n % 3 === 0)
+      if (n % 4 === 0)
+        process.nextTick(cb4, 3.14, 1024, true, false);
+      else if (n % 3 === 0)
         process.nextTick(cb3, 512, true, null);
       else if (n % 2 === 0)
         process.nextTick(cb2, false, 5.1);
@@ -23,7 +38,9 @@ function main(conf) {
   }
   function cb2(arg1, arg2) {
     if (--n) {
-      if (n % 3 === 0)
+      if (n % 4 === 0)
+        process.nextTick(cb4, 3.14, 1024, true, false);
+      else if (n % 3 === 0)
         process.nextTick(cb3, 512, true, null);
       else if (n % 2 === 0)
         process.nextTick(cb2, false, 5.1);
@@ -34,7 +51,9 @@ function main(conf) {
   }
   function cb1(arg1) {
     if (--n) {
-      if (n % 3 === 0)
+      if (n % 4 === 0)
+        process.nextTick(cb4, 3.14, 1024, true, false);
+      else if (n % 3 === 0)
         process.nextTick(cb3, 512, true, null);
       else if (n % 2 === 0)
         process.nextTick(cb2, false, 5.1);