Skip to content

Commit

Permalink
deps: V8: cherry-pick b60a03df4ceb
Browse files Browse the repository at this point in the history
Original commit message:

    [api] mark v8::Script and v8::UnboundScript as v8::Data

    v8::UnboundModuleScript and v8::Module are already v8::Data.
    Mark v8::Script and v8::UnboundScript as v8::Data so that they
    can be used in other V8 APIs that takes v8::Data.

    Refs: #48510

    Bug: v8:14120
    Change-Id: I2dd5648528c1b0030292872441758d4fb2cfcc1c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4827307
    Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#89727}

Refs: v8/v8@b60a03d
PR-URL: #49491
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
  • Loading branch information
joyeecheung authored Sep 12, 2023
1 parent e4d1259 commit 668437c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.16',
'v8_embedder_string': '-node.17',

##### V8 defaults for Node.js #####

Expand Down
4 changes: 2 additions & 2 deletions deps/v8/include/v8-script.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class V8_EXPORT ScriptOrModule {
/**
* A compiled JavaScript script, not yet tied to a Context.
*/
class V8_EXPORT UnboundScript {
class V8_EXPORT UnboundScript : public Data {
public:
/**
* Binds the script to the currently entered context.
Expand Down Expand Up @@ -320,7 +320,7 @@ class V8_EXPORT Module : public Data {
* A compiled JavaScript script, tied to a Context which was active when the
* script was compiled.
*/
class V8_EXPORT Script {
class V8_EXPORT Script : public Data {
public:
/**
* A shorthand for ScriptCompiler::Compile().
Expand Down

0 comments on commit 668437c

Please sign in to comment.