Skip to content

Commit

Permalink
test: change Fixes: to Refs:
Browse files Browse the repository at this point in the history
Tests don't fix things generally, so use "Refs:" to refer people to
GitHub issues.

PR-URL: #34568
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott committed Aug 2, 2020
1 parent aeaf161 commit 73d713b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion test/parallel/test-fs-symlink.js
Expand Up @@ -58,7 +58,7 @@ fs.symlink(linkData, linkPath, common.mustCall(function(err) {
}));

tmpdir.refresh();
// Fixes: https://github.com/nodejs/node/issues/34514
// Refs: https://github.com/nodejs/node/issues/34514
fs.symlinkSync(Buffer.from(linkData), linkPath);
}));

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-http-outgoing-message-inheritance.js
Expand Up @@ -6,8 +6,8 @@ const { Writable } = require('stream');
const assert = require('assert');

// Check that OutgoingMessage can be used without a proper Socket
// Fixes: https://github.com/nodejs/node/issues/14386
// Fixes: https://github.com/nodejs/node/issues/14381
// Refs: https://github.com/nodejs/node/issues/14386
// Refs: https://github.com/nodejs/node/issues/14381

class Response extends OutgoingMessage {
_implicitHeader() {}
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-http-server-response-standalone.js
Expand Up @@ -6,8 +6,8 @@ const { Writable } = require('stream');
const assert = require('assert');

// Check that ServerResponse can be used without a proper Socket
// Fixes: https://github.com/nodejs/node/issues/14386
// Fixes: https://github.com/nodejs/node/issues/14381
// Refs: https://github.com/nodejs/node/issues/14386
// Refs: https://github.com/nodejs/node/issues/14381

const res = new ServerResponse({
method: 'GET',
Expand Down

0 comments on commit 73d713b

Please sign in to comment.