Skip to content

Commit

Permalink
src: remove req_wrap-inl.h from stream_base.h
Browse files Browse the repository at this point in the history
This commit removes the inclusion of req_wrap-inl.h in stream_base.h
as ReqWrap is not used. This removal required stream_base.h to include
async_wrap-inl.h so there is an implementation of BaseObject::object.

The above change also affected connect_wrap, which needs to include
req_wrap-inl.h to get an implementation of ReqWrap::Dispatched.

PR-URL: #20063
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
  • Loading branch information
danbev authored and jasnell committed Apr 19, 2018
1 parent 1396996 commit 8e969b6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/connect_wrap.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "env.h"
#include "req_wrap.h"
#include "req_wrap-inl.h"
#include "async_wrap.h"
#include "v8.h"

Expand Down
3 changes: 1 addition & 2 deletions src/stream_base.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#include "env.h"
#include "async_wrap.h"
#include "req_wrap-inl.h"
#include "async_wrap-inl.h"
#include "node.h"
#include "util.h"

Expand Down

0 comments on commit 8e969b6

Please sign in to comment.