src: remove req_wrap-inl.h from stream_base.h #20063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the inclusion of req_wrap-inl.h in stream_base.h as ReqWrap is not used. This removal required stream_base.h to include async_wrap-inl.h so there is an implementation of BaseObject::object. The above change also affected connect_wrap, which needs to include req_wrap-inl.h to get an implementation of ReqWrap::Dispatched.
nodejs-github-bot
added
c++
jasnell
approved these changes
Apr 16, 2018
addaleax
approved these changes
Apr 16, 2018
|
Re-building Linux CI: https://ci.nodejs.org/job/node-test-commit-linux/18066/ |
TimothyGu
approved these changes
Apr 16, 2018
BridgeAR
added
the
author ready
|
Landed in d864f63. |
danbev
added a commit
that referenced
this pull request
Apr 18, 2018
This commit removes the inclusion of req_wrap-inl.h in stream_base.h as ReqWrap is not used. This removal required stream_base.h to include async_wrap-inl.h so there is an implementation of BaseObject::object. The above change also affected connect_wrap, which needs to include req_wrap-inl.h to get an implementation of ReqWrap::Dispatched. PR-URL: #20063 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2018
This commit removes the inclusion of req_wrap-inl.h in stream_base.h as ReqWrap is not used. This removal required stream_base.h to include async_wrap-inl.h so there is an implementation of BaseObject::object. The above change also affected connect_wrap, which needs to include req_wrap-inl.h to get an implementation of ReqWrap::Dispatched. PR-URL: #20063 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the inclusion of req_wrap-inl.h in stream_base.h
as ReqWrap is not used. This removal required stream_base.h to include
async_wrap-inl.h so there is an implementation of BaseObject::object.
The above change also affected connect_wrap, which needs to include
req_wrap-inl.h to get an implementation of ReqWrap::Dispatched.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes