Permalink
Browse files

test: add common.mustCall() to NAPI exception test

Use `common.mustCall()` to confirm that function is invoked.

PR-URL: #12959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
Trott committed May 11, 2017
1 parent 84fc069 commit 9516aa19c16cbfda6917c4fb8d6aecf2da8a16aa
Showing with 2 additions and 4 deletions.
  1. +2 −4 test/addons-napi/test_exception/test.js
@@ -9,8 +9,6 @@ function throwTheError() {
}
let caughtError;
const throwNoError = common.noop;
// Test that the native side successfully captures the exception
let returnedError = test_exception.returnException(throwTheError);
assert.strictEqual(theError, returnedError,
@@ -34,13 +32,13 @@ assert.strictEqual(test_exception.wasPending(), true,
' when it was allowed through');
// Test that the native side does not capture a non-existing exception
returnedError = test_exception.returnException(throwNoError);
returnedError = test_exception.returnException(common.mustCall());
assert.strictEqual(undefined, returnedError,
'Returned error is undefined when no exception is thrown');
// Test that no exception appears that was not thrown by us
try {
test_exception.allowException(throwNoError);
test_exception.allowException(common.mustCall());
} catch (anError) {
caughtError = anError;
}

0 comments on commit 9516aa1

Please sign in to comment.