Skip to content

Commit

Permalink
src: update NODE_MODULE_VERSION to 51
Browse files Browse the repository at this point in the history
When V8 was updated on master to 5.4 there were ABI breaking changes.
In the past we have not landed these types of changes before a release,
and as such have only bumped the NODE_MODULE_VERSION number in the
release commit.

Since we are going to be keeping the V8 5.4 beta on master and in the
v7 betas I think it makes sense for us to bump the module number prior
to a release commit being made. It is possible that this commit should
be reverted prior to v7.0.0 being cut. Alternatively we may want to
modify our release process for V8 to include a NODE_MODULE_VERSION
bump before landing on master when applicable.

NODE_MODULE_VERSION is being bumped to 51 instead of 49 to avoid
conflicts with NODE_MODULE_VERSIONs being used in electron.

Ref: electron/electron#5851 (comment)
Ref: #8317

PR-URL: #8808
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: MichaΓ«l Zasso <mic.besace@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
Myles Borins authored and jasnell committed Sep 29, 2016
1 parent a88bb3a commit 96933df
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/node_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@
* an API is broken in the C++ side, including in v8 or
* other dependencies.
*/
#define NODE_MODULE_VERSION 48 /* Node.js v6.0.0 */
#define NODE_MODULE_VERSION 51 /* Node.js v7.0.0 */

#endif // SRC_NODE_VERSION_H_

3 comments on commit 96933df

@rgbkrk
Copy link

@rgbkrk rgbkrk commented on 96933df Sep 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're my hero for acknowledging this and making it easier to keep both node and Electron moving forward for users.

@MylesBorins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was the work of the entire CTC. πŸ˜‡

@rgbkrk
Copy link

@rgbkrk rgbkrk commented on 96933df Sep 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ™‡ Thank you entire CTC

Please sign in to comment.