deps: update V8 to 5.4 #8317

targos · 2016-08-29T07:41:54Z

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

V8

Description of change

This PR replaces #7824
Previous discussion: targos#1

~~CI: https://ci.nodejs.org/job/node-test-pull-request/3870/~~
~~CI: https://ci.nodejs.org/job/node-test-pull-request/3876/~~
~~CI: https://ci.nodejs.org/job/node-test-pull-request/3883/~~
~~CI: https://ci.nodejs.org/job/node-test-pull-request/3953/~~

~~CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/376/~~
~~CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/379/~~

vitkarpov · 2016-08-29T08:11:45Z

+12,599 lines

mhdawson · 2016-08-29T14:13:36Z

V8 CI Run: https://ci.nodejs.org/job/node-test-commit-v8-linux/285/

mhdawson · 2016-08-29T14:50:36Z

Failures on ppc, 5.4 is not yet beta which is the point at which we have made sure all commits have had it over from master to new branches which is probably why we are seeing these failures. Would like to make sure 5.4 is green on ppc/zLinux before we update master.

mscdex · 2016-08-29T15:25:07Z

@vitkarpov My guess is that the new Ignition interpreter accounts for most of that

jbajwa · 2016-08-29T15:34:52Z

I've opened a CL to backport the fix to 5.4. Should be clean after its merged.
https://codereview.chromium.org/2290603004/

jbergstroem · 2016-08-29T18:36:59Z

CI on alpine34: https://ci.nodejs.org/job/node-test-commit-jbergstroem-alpine34/12/nodes=alpine34-x64/ (musl based toolchain, lacks execinfo.h)

i5ting · 2016-08-29T22:57:11Z

nice job

mhdawson · 2016-08-30T16:00:43Z

@jbajwa tells me the backported CL landed in the google repos. If this can be updated to the include the latest 5.4 the PPC issues should be resolved. Once that happens we can start another v8 CI run.

targos · 2016-08-30T18:27:37Z

@mhdawson I updated the branch

Edit: V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/294/

mhdawson · 2016-08-30T21:44:48Z

@jbawa, looks better but still 3 failures on le, https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=ppcle-ubuntu1404,v8test=v8test/295/console

Not sure what is going on today but I had to clean the workspace again, I wonder if it has something to do with the different V8 levels (ie 5.4 versus 5.1 in master).

jbajwa · 2016-08-30T22:10:32Z

@mhdawson
Those are the 2 remaining issues which only affect native. I have an issue opened for same on the ibmruntimes fork of v8. I'm working on it now.

mhdawson · 2016-09-06T19:25:56Z

Problem on linuxOne should now be resolved see: #8329

The PPC issues are still being worked.

jbajwa · 2016-09-07T13:32:02Z

The 2 remaining PPC issues are testcase issues. I've opened CLs to upstream the fix.
https://codereview.chromium.org/2314843003/
https://codereview.chromium.org/2314343002/
Will backport to 5.4 once they are in v8 master.

jasnell · 2016-09-08T19:48:27Z

Just an FYI, I will be cutting the v7.x branch the morning of Monday Sept 12th.

ofrobots · 2016-09-08T22:29:38Z

I think the outstanding work here is:

Pick up the latest V8 5.4.500.20 which includes a workaround for issues related to gcc-6+ deleting null pointer comparisons.
Ensure that the 2 changes from @jbajwa get merged back to V8 5.4. (@jbajwa: do you think this can be done before Monday?)
@targos is working on upstreaming bb8da0a as https://codereview.chromium.org/2321433003/, but the code-review needs to be worked through. (@targos: do you think you will have time to get this finished & landed on Friday? Let me know if I can help). This is needed for Solaris and Alpine builds. Once it lands it needs to be merged back into the V8 5.4 branch. I am not sure if we have enough time left to get this done before Monday. /cc @natorion.

jbajwa · 2016-09-09T01:26:44Z

@ofrobots
The 2 CLs are in V8 master now. Should be backported to 5.4 by tomorrow. Will add an update once that is done.

Notable Changes: * Buffer * Passing invalid input to Buffer.byteLength will now throw an error [nodejs#8946](nodejs#8946). * Calling Buffer without new is now deprecated and will emit a process warning [nodejs#8169](nodejs#8169). * Passing a negative number to allocUnsafe will now throw an error [nodejs#7079](nodejs#7079). * Child Process * The fork and execFile methods now have stronger argument validation [nodejs#7399](nodejs#7399). * Cluster * The worker.suicide method is deprecated and will emit a process warning [nodejs#3747](nodejs#3747). * Deps * V8 has been updated to 5.4.500.36 [nodejs#8317](nodejs#8317), [nodejs#8852](nodejs#8852), [nodejs#9253](nodejs#9253). * NODE_MODULE_VERSION has been updated to 51 [nodejs#8808](nodejs#8808). * File System * A process warning is emitted if a callback is not passed to async file system methods [nodejs#7897](nodejs#7897). * Intl * Intl.v8BreakIterator constructor has been deprecated and will emit a process warning [nodejs#8908](nodejs#8908). * Promises * Unhandled Promise rejections have been deprecated and will emit a process warning [nodejs#8217](nodejs#8217). * Punycode * The `punycode` module has been deprecated [nodejs#7941](nodejs#7941). * URL * An Experimental WHATWG URL Parser has been introduced [nodejs#7448](nodejs#7448).

Notable Changes: * Buffer * Passing invalid input to Buffer.byteLength will now throw an error [#8946](#8946). * Calling Buffer without new is now deprecated and will emit a process warning [#8169](#8169). * Passing a negative number to allocUnsafe will now throw an error [#7079](#7079). * Child Process * The fork and execFile methods now have stronger argument validation [#7399](#7399). * Cluster * The worker.suicide method is deprecated and will emit a process warning [#3747](#3747). * Deps * V8 has been updated to 5.4.500.36 [#8317](#8317), [#8852](#8852), [#9253](#9253). * NODE_MODULE_VERSION has been updated to 51 [#8808](#8808). * File System * A process warning is emitted if a callback is not passed to async file system methods [#7897](#7897). * Intl * Intl.v8BreakIterator constructor has been deprecated and will emit a process warning [#8908](#8908). * Promises * Unhandled Promise rejections have been deprecated and will emit a process warning [#8217](#8217). * Punycode * The `punycode` module has been deprecated [#7941](#7941). * URL * An Experimental WHATWG URL Parser has been introduced [#7448](#7448). PR-URL: #9099

Notable Changes: * Buffer * Passing invalid input to Buffer.byteLength will now throw an error [#8946](nodejs/node#8946). * Calling Buffer without new is now deprecated and will emit a process warning [#8169](nodejs/node#8169). * Passing a negative number to allocUnsafe will now throw an error [#7079](nodejs/node#7079). * Child Process * The fork and execFile methods now have stronger argument validation [#7399](nodejs/node#7399). * Cluster * The worker.suicide method is deprecated and will emit a process warning [#3747](nodejs/node#3747). * Deps * V8 has been updated to 5.4.500.36 [#8317](nodejs/node#8317), [#8852](nodejs/node#8852), [#9253](nodejs/node#9253). * NODE_MODULE_VERSION has been updated to 51 [#8808](nodejs/node#8808). * File System * A process warning is emitted if a callback is not passed to async file system methods [#7897](nodejs/node#7897). * Intl * Intl.v8BreakIterator constructor has been deprecated and will emit a process warning [#8908](nodejs/node#8908). * Promises * Unhandled Promise rejections have been deprecated and will emit a process warning [#8217](nodejs/node#8217). * Punycode * The `punycode` module has been deprecated [#7941](nodejs/node#7941). * URL * An Experimental WHATWG URL Parser has been introduced [#7448](nodejs/node#7448). Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

Ref: nodejs#8343 Fixes: nodejs#8323 PR-URL: nodejs#8317 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

Fixes: nodejs#8323 Refs: nodejs#8343 Refs: nodejs#8317 PR-URL: nodejs#11029 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>

targos added wip Issues and PRs that are still a work in progress. v8 engine Issues and PRs related to the V8 dependency. dont-land-on-v4.x labels Aug 29, 2016

targos added this to the 7.0.0 milestone Aug 29, 2016

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 29, 2016

targos mentioned this pull request Aug 29, 2016

[WIP] Update V8 to 5.2 #7824

Closed

2 tasks

rattrayalex mentioned this pull request Aug 29, 2016

Koa 2.0.0 koajs/koa#533

Closed

targos force-pushed the v8-5.4 branch from 65c03b4 to 61f5e46 Compare August 30, 2016 13:52

ofrobots mentioned this pull request Aug 30, 2016

v6.5.0 fails to build using clang-3.4. #8323

Closed

targos force-pushed the v8-5.4 branch from c9e6a24 to 6cb4721 Compare August 31, 2016 16:24

targos force-pushed the v8-5.4 branch from 6cb4721 to b7d14b7 Compare September 6, 2016 20:53

yortus mentioned this pull request Sep 8, 2016

Add ES2017 Target microsoft/TypeScript#10768

Closed

targos force-pushed the v8-5.4 branch from 13ba9c4 to bb8da0a Compare September 8, 2016 07:55

targos mentioned this pull request Oct 19, 2016

v7.0.0 Proposal #9099

Closed

Trott removed the ctc-agenda label Oct 20, 2016

targos added a commit to targos/node that referenced this pull request Dec 30, 2016

deps: cherry-pick workaround for clang-3.4 ICE

f5d459f

Ref: nodejs#8343 Fixes: nodejs#8323 PR-URL: nodejs#8317 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

kevinsawicki mentioned this pull request Jan 23, 2017

Support standard C++ headers / libs when building addons for Electron electron/electron#8481

Closed

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

bzoz mentioned this pull request Jun 19, 2017

32bit address given for 64bit builds using --prof on Windows #8221

Closed

jaimecbernardo mentioned this pull request Jul 27, 2017

deps,profiler: parse Windows' "%p" in processor #14510

Closed

2 tasks

MylesBorins added the dont-land-on-v6.x label Jan 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 5.4 #8317

deps: update V8 to 5.4 #8317

targos commented Aug 29, 2016 •

edited

vitkarpov commented Aug 29, 2016

mhdawson commented Aug 29, 2016 •

edited

mhdawson commented Aug 29, 2016

mscdex commented Aug 29, 2016

jbajwa commented Aug 29, 2016

jbergstroem commented Aug 29, 2016 •

edited

i5ting commented Aug 29, 2016

mhdawson commented Aug 30, 2016

targos commented Aug 30, 2016 •

edited

mhdawson commented Aug 30, 2016

jbajwa commented Aug 30, 2016

mhdawson commented Sep 6, 2016 •

edited

jbajwa commented Sep 7, 2016

jasnell commented Sep 8, 2016

ofrobots commented Sep 8, 2016 •

edited

jbajwa commented Sep 9, 2016 •

edited

deps: update V8 to 5.4 #8317

deps: update V8 to 5.4 #8317

Conversation

targos commented Aug 29, 2016 • edited

Checklist

Affected core subsystem(s)

Description of change

vitkarpov commented Aug 29, 2016

mhdawson commented Aug 29, 2016 • edited

mhdawson commented Aug 29, 2016

mscdex commented Aug 29, 2016

jbajwa commented Aug 29, 2016

jbergstroem commented Aug 29, 2016 • edited

i5ting commented Aug 29, 2016

mhdawson commented Aug 30, 2016

targos commented Aug 30, 2016 • edited

mhdawson commented Aug 30, 2016

jbajwa commented Aug 30, 2016

mhdawson commented Sep 6, 2016 • edited

jbajwa commented Sep 7, 2016

jasnell commented Sep 8, 2016

ofrobots commented Sep 8, 2016 • edited

jbajwa commented Sep 9, 2016 • edited

targos commented Aug 29, 2016 •

edited

mhdawson commented Aug 29, 2016 •

edited

jbergstroem commented Aug 29, 2016 •

edited

targos commented Aug 30, 2016 •

edited

mhdawson commented Sep 6, 2016 •

edited

ofrobots commented Sep 8, 2016 •

edited

jbajwa commented Sep 9, 2016 •

edited