New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 5.4 #8317

Merged
merged 9 commits into from Sep 22, 2016

Conversation

Projects
None yet
@targos
Member

targos commented Aug 29, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

Description of change

This PR replaces #7824
Previous discussion: targos#1

CI: https://ci.nodejs.org/job/node-test-pull-request/3870/
CI: https://ci.nodejs.org/job/node-test-pull-request/3876/
CI: https://ci.nodejs.org/job/node-test-pull-request/3883/
CI: https://ci.nodejs.org/job/node-test-pull-request/3953/

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/376/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/379/

@targos targos added this to the 7.0.0 milestone Aug 29, 2016

@targos targos referenced this pull request Aug 29, 2016

Closed

[WIP] Update V8 to 5.2 #7824

1 of 2 tasks complete
@vitkarpov

This comment has been minimized.

Contributor

vitkarpov commented Aug 29, 2016

+12,599 lines

@rattrayalex rattrayalex referenced this pull request Aug 29, 2016

Closed

Koa 2.0.0 #533

@mhdawson

This comment has been minimized.

Member

mhdawson commented Aug 29, 2016

@mhdawson

This comment has been minimized.

Member

mhdawson commented Aug 29, 2016

Failures on ppc, 5.4 is not yet beta which is the point at which we have made sure all commits have had it over from master to new branches which is probably why we are seeing these failures. Would like to make sure 5.4 is green on ppc/zLinux before we update master.

@mscdex

This comment has been minimized.

Contributor

mscdex commented Aug 29, 2016

@vitkarpov My guess is that the new Ignition interpreter accounts for most of that

@jbajwa

This comment has been minimized.

Member

jbajwa commented Aug 29, 2016

I've opened a CL to backport the fix to 5.4. Should be clean after its merged.
https://codereview.chromium.org/2290603004/

@jbergstroem

This comment has been minimized.

Member

jbergstroem commented Aug 29, 2016

CI on alpine34: https://ci.nodejs.org/job/node-test-commit-jbergstroem-alpine34/12/nodes=alpine34-x64/ (musl based toolchain, lacks execinfo.h)

@i5ting

This comment has been minimized.

i5ting commented Aug 29, 2016

nice job

@targos targos force-pushed the targos:v8-5.4 branch Aug 30, 2016

@mhdawson

This comment has been minimized.

Member

mhdawson commented Aug 30, 2016

@jbajwa tells me the backported CL landed in the google repos. If this can be updated to the include the latest 5.4 the PPC issues should be resolved. Once that happens we can start another v8 CI run.

@targos

This comment has been minimized.

Member

targos commented Aug 30, 2016

@mhdawson

This comment has been minimized.

Member

mhdawson commented Aug 30, 2016

@jbawa, looks better but still 3 failures on le, https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=ppcle-ubuntu1404,v8test=v8test/295/console

Not sure what is going on today but I had to clean the workspace again, I wonder if it has something to do with the different V8 levels (ie 5.4 versus 5.1 in master).

@jbajwa

This comment has been minimized.

Member

jbajwa commented Aug 30, 2016

@mhdawson
Those are the 2 remaining issues which only affect native. I have an issue opened for same on the ibmruntimes fork of v8. I'm working on it now.

@targos targos force-pushed the targos:v8-5.4 branch Aug 31, 2016

@mhdawson

This comment has been minimized.

Member

mhdawson commented Sep 6, 2016

Problem on linuxOne should now be resolved see: #8329

The PPC issues are still being worked.

@targos targos force-pushed the targos:v8-5.4 branch Sep 6, 2016

@jbajwa

This comment has been minimized.

Member

jbajwa commented Sep 7, 2016

The 2 remaining PPC issues are testcase issues. I've opened CLs to upstream the fix.
https://codereview.chromium.org/2314843003/
https://codereview.chromium.org/2314343002/
Will backport to 5.4 once they are in v8 master.

@yortus yortus referenced this pull request Sep 8, 2016

Closed

Add ES2017 Target #10768

@targos targos force-pushed the targos:v8-5.4 branch Sep 8, 2016

@jasnell

This comment has been minimized.

Member

jasnell commented Sep 8, 2016

Just an FYI, I will be cutting the v7.x branch the morning of Monday Sept 12th.

@ofrobots

This comment has been minimized.

Contributor

ofrobots commented Sep 8, 2016

I think the outstanding work here is:

  • Pick up the latest V8 5.4.500.20 which includes a workaround for issues related to gcc-6+ deleting null pointer comparisons.
  • Ensure that the 2 changes from @jbajwa get merged back to V8 5.4. (@jbajwa: do you think this can be done before Monday?)
  • @targos is working on upstreaming bb8da0a as https://codereview.chromium.org/2321433003/, but the code-review needs to be worked through. (@targos: do you think you will have time to get this finished & landed on Friday? Let me know if I can help). This is needed for Solaris and Alpine builds. Once it lands it needs to be merged back into the V8 5.4 branch. I am not sure if we have enough time left to get this done before Monday. /cc @natorion.
@jbajwa

This comment has been minimized.

Member

jbajwa commented Sep 9, 2016

@ofrobots
The 2 CLs are in V8 master now. Should be backported to 5.4 by tomorrow. Will add an update once that is done.

@targos targos referenced this pull request Oct 19, 2016

Closed

v7.0.0 Proposal #9099

@Trott Trott removed the ctc-agenda label Oct 20, 2016

jasnell added a commit to jasnell/node that referenced this pull request Oct 24, 2016

2016-10-25, Version 7.0.0 (Current)
Notable Changes:

* Buffer
  * Passing invalid input to Buffer.byteLength will now throw an error [nodejs#8946](nodejs#8946).
  * Calling Buffer without new is now deprecated and will emit a process warning [nodejs#8169](nodejs#8169).
  * Passing a negative number to allocUnsafe will now throw an error [nodejs#7079](nodejs#7079).
* Child Process
  * The fork and execFile methods now have stronger argument validation [nodejs#7399](nodejs#7399).
* Cluster
  * The worker.suicide method is deprecated and will emit a process warning [nodejs#3747](nodejs#3747).
* Deps
  * V8 has been updated to 5.4.500.36 [nodejs#8317](nodejs#8317), [nodejs#8852](nodejs#8852), [nodejs#9253](nodejs#9253).
  * NODE_MODULE_VERSION has been updated to 51 [nodejs#8808](nodejs#8808).
* File System
  * A process warning is emitted if a callback is not passed to async file system methods [nodejs#7897](nodejs#7897).
* Intl
  * Intl.v8BreakIterator constructor has been deprecated and will emit a process warning [nodejs#8908](nodejs#8908).
* Promises
  * Unhandled Promise rejections have been deprecated and will emit a process warning [nodejs#8217](nodejs#8217).
* Punycode
  * The `punycode` module has been deprecated [nodejs#7941](nodejs#7941).
* URL
  * An Experimental WHATWG URL Parser has been introduced [nodejs#7448](nodejs#7448).

jasnell added a commit that referenced this pull request Oct 25, 2016

2016-10-25, Version 7.0.0 (Current)
Notable Changes:

* Buffer
  * Passing invalid input to Buffer.byteLength will now throw an error [#8946](#8946).
  * Calling Buffer without new is now deprecated and will emit a process warning [#8169](#8169).
  * Passing a negative number to allocUnsafe will now throw an error [#7079](#7079).
* Child Process
  * The fork and execFile methods now have stronger argument validation [#7399](#7399).
* Cluster
  * The worker.suicide method is deprecated and will emit a process warning [#3747](#3747).
* Deps
  * V8 has been updated to 5.4.500.36 [#8317](#8317), [#8852](#8852), [#9253](#9253).
  * NODE_MODULE_VERSION has been updated to 51 [#8808](#8808).
* File System
  * A process warning is emitted if a callback is not passed to async file system methods [#7897](#7897).
* Intl
  * Intl.v8BreakIterator constructor has been deprecated and will emit a process warning [#8908](#8908).
* Promises
  * Unhandled Promise rejections have been deprecated and will emit a process warning [#8217](#8217).
* Punycode
  * The `punycode` module has been deprecated [#7941](#7941).
* URL
  * An Experimental WHATWG URL Parser has been introduced [#7448](#7448).

PR-URL: #9099

jasnell added a commit that referenced this pull request Oct 25, 2016

2016-10-25, Version 7.0.0 (Current)
Notable Changes:

* Buffer
  * Passing invalid input to Buffer.byteLength will now throw an error [#8946](#8946).
  * Calling Buffer without new is now deprecated and will emit a process warning [#8169](#8169).
  * Passing a negative number to allocUnsafe will now throw an error [#7079](#7079).
* Child Process
  * The fork and execFile methods now have stronger argument validation [#7399](#7399).
* Cluster
  * The worker.suicide method is deprecated and will emit a process warning [#3747](#3747).
* Deps
  * V8 has been updated to 5.4.500.36 [#8317](#8317), [#8852](#8852), [#9253](#9253).
  * NODE_MODULE_VERSION has been updated to 51 [#8808](#8808).
* File System
  * A process warning is emitted if a callback is not passed to async file system methods [#7897](#7897).
* Intl
  * Intl.v8BreakIterator constructor has been deprecated and will emit a process warning [#8908](#8908).
* Promises
  * Unhandled Promise rejections have been deprecated and will emit a process warning [#8217](#8217).
* Punycode
  * The `punycode` module has been deprecated [#7941](#7941).
* URL
  * An Experimental WHATWG URL Parser has been introduced [#7448](#7448).

PR-URL: #9099

imyller added a commit to imyller/meta-nodejs that referenced this pull request Oct 25, 2016

2016-10-25, Version 7.0.0 (Current)
    Notable Changes:

    * Buffer
      * Passing invalid input to Buffer.byteLength will now throw an error [#8946](nodejs/node#8946).
      * Calling Buffer without new is now deprecated and will emit a process warning [#8169](nodejs/node#8169).
      * Passing a negative number to allocUnsafe will now throw an error [#7079](nodejs/node#7079).
    * Child Process
      * The fork and execFile methods now have stronger argument validation [#7399](nodejs/node#7399).
    * Cluster
      * The worker.suicide method is deprecated and will emit a process warning [#3747](nodejs/node#3747).
    * Deps
      * V8 has been updated to 5.4.500.36 [#8317](nodejs/node#8317), [#8852](nodejs/node#8852), [#9253](nodejs/node#9253).
      * NODE_MODULE_VERSION has been updated to 51 [#8808](nodejs/node#8808).
    * File System
      * A process warning is emitted if a callback is not passed to async file system methods [#7897](nodejs/node#7897).
    * Intl
      * Intl.v8BreakIterator constructor has been deprecated and will emit a process warning [#8908](nodejs/node#8908).
    * Promises
      * Unhandled Promise rejections have been deprecated and will emit a process warning [#8217](nodejs/node#8217).
    * Punycode
      * The `punycode` module has been deprecated [#7941](nodejs/node#7941).
    * URL
      * An Experimental WHATWG URL Parser has been introduced [#7448](nodejs/node#7448).

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

targos added a commit to targos/node that referenced this pull request Dec 30, 2016

deps: cherry-pick workaround for clang-3.4 ICE
Ref: nodejs#8343
Fixes: nodejs#8323

PR-URL: nodejs#8317
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

MylesBorins added a commit to MylesBorins/node that referenced this pull request Feb 1, 2017

deps: cherry-pick workaround for clang-3.4 ICE
Ref: nodejs#8343
Fixes: nodejs#8323

PR-URL: nodejs#8317
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

targos added a commit to targos/node that referenced this pull request Feb 7, 2017

deps: cherry-pick workaround for clang-3.4 ICE
Fixes: nodejs#8323
Refs: nodejs#8343
Refs: nodejs#8317

PR-URL: nodejs#11029
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

italoacasas added a commit to italoacasas/node that referenced this pull request Feb 14, 2017

deps: cherry-pick workaround for clang-3.4 ICE
Fixes: nodejs#8323
Refs: nodejs#8343
Refs: nodejs#8317

PR-URL: nodejs#11029
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

@jaimecbernardo jaimecbernardo referenced this pull request Jul 27, 2017

Closed

deps,profiler: parse Windows' "%p" in processor #14510

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment