Skip to content

Commit

Permalink
doc: remove "maintenance is supported by" text in BUILDING.md
Browse files Browse the repository at this point in the history
The "maintenance is supported by" stuff in BUILDING.md is unclear. It
seems unnecessary so I propose removing it.

I don't understand what it means to, in this context, support
maintenance. Does it mean that you simply do the maintenance? Does that
mean it really just means "maintain"? Do we really mean that we mantain
support, rather than support maintenance?

That information does not seem necessary to include. I'm not sure it's
meaningful. With (for example) Windows, is it accurate to say that the
Node.js core team maintains support for it? Or is it accurate to say
that support is maintaned by smaller groups or individuals within the
Node.js core team?  Both could be considered accurate. So is the
difference meaningful?

I think the more important elements of determinig tier support are the
other listed elements.

PR-URL: #30365
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
Trott authored and targos committed Dec 1, 2019
1 parent be0b53d commit a7d552c
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,14 @@ There are three support tiers:

* **Tier 1**: These platforms represent the majority of Node.js users. The
Node.js Build Working Group maintains infrastructure for full test coverage.
Maintenance is supported by the Node.js core team. All commits to the
Node.js repository are tested on multiple variants of these platforms. Test
failures on tier 1 platforms will block releases.
All commits to the Node.js repository are tested on multiple variants of these
platforms. Test failures on tier 1 platforms will block releases.
* **Tier 2**: These platforms represent smaller segments of the Node.js user
base. The Node.js Build Working Group maintains infrastructure for full test
coverage. Maintenance is supported by smaller groups or individuals within
the Node.js core team, or the vendor of the platform itself. All commits to
the Node.js repository are tested on multiple variants of these platforms
where practical. Test failures on tier 2 platforms will block releases.
Delays in release of binaries for these platforms are acceptable
where necessary due to infrastructure concerns.
coverage. All commits to the Node.js repository are tested on multiple
variants of these platforms where practical. Test failures on tier 2 platforms
will block releases. Delays in release of binaries for these platforms are
acceptable where necessary due to infrastructure concerns.
* **Experimental**: May not compile or test suite may not pass. The core team
does not create releases for these platforms. Test failures on experimental
platforms do not block releases. Contributions to improve support for these
Expand Down

0 comments on commit a7d552c

Please sign in to comment.