Skip to content

Commit

Permalink
test: add trailing commas in test/known_issues
Browse files Browse the repository at this point in the history
PR-URL: #46408
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
aduh95 authored and MylesBorins committed Feb 18, 2023
1 parent a66e7ca commit c7f29b2
Show file tree
Hide file tree
Showing 11 changed files with 14 additions and 15 deletions.
1 change: 0 additions & 1 deletion test/.eslintrc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ overrides:
- es-module/*.js
- es-module/*.mjs
- js-native-api/*/*.js
- known_issues/*.js
- parallel/*.js
- parallel/*.mjs
- pummel/*.js
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@ if (cluster.isPrimary) {
socket1.on('error', PRT1 === 0 ? () => {} : assert.fail);
socket1.bind(
{ address: common.localhostIPv4, port: PRT1, exclusive: false },
() => process.send({ message: 'success', port1: socket1.address().port })
() => process.send({ message: 'success', port1: socket1.address().port }),
);
}
2 changes: 1 addition & 1 deletion test/known_issues/test-http-path-contains-unicode.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ server.listen(0, () => {
http.request({
port: server.address().port,
path: expected,
method: 'GET'
method: 'GET',
}, common.mustCall(function(res) {
res.resume();
})).on('error', function(e) {
Expand Down
2 changes: 1 addition & 1 deletion test/known_issues/test-repl-require-context.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const fixture = path('is-object.js');
const r = repl.start({
input: inputStream,
output: outputStream,
useGlobal: false
useGlobal: false,
});

let output = '';
Expand Down
2 changes: 1 addition & 1 deletion test/known_issues/test-stdin-is-always-net.socket.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ if (process.argv[2] === 'child') {
const proc = spawn(
process.execPath,
[__filename, 'child'],
{ stdio: 'ignore' }
{ stdio: 'ignore' },
);
// To double-check this test, set stdio to 'pipe' and uncomment the line below.
// proc.stderr.pipe(process.stderr);
Expand Down
2 changes: 1 addition & 1 deletion test/known_issues/test-url-parse-conformance.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const url = require('url');
const assert = require('assert');
const fixtures = require('../common/fixtures');
const tests = require(
fixtures.path('wpt', 'url', 'resources', 'urltestdata.json')
fixtures.path('wpt', 'url', 'resources', 'urltestdata.json'),
);

let failed = 0;
Expand Down
2 changes: 1 addition & 1 deletion test/known_issues/test-vm-ownkeys.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const sym1 = Symbol('1');
const sym2 = Symbol('2');
const sandbox = {
a: true,
[sym1]: true
[sym1]: true,
};
Object.defineProperty(sandbox, 'b', { value: true });
Object.defineProperty(sandbox, sym2, { value: true });
Expand Down
2 changes: 1 addition & 1 deletion test/known_issues/test-vm-ownpropertynames.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const sym1 = Symbol('1');
const sym2 = Symbol('2');
const sandbox = {
a: true,
[sym1]: true
[sym1]: true,
};
Object.defineProperty(sandbox, 'b', { value: true });
Object.defineProperty(sandbox, sym2, { value: true });
Expand Down
2 changes: 1 addition & 1 deletion test/known_issues/test-vm-ownpropertysymbols.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const sym1 = Symbol('1');
const sym2 = Symbol('2');
const sandbox = {
a: true,
[sym1]: true
[sym1]: true,
};
Object.defineProperty(sandbox, 'b', { value: true });
Object.defineProperty(sandbox, sym2, { value: true });
Expand Down
6 changes: 3 additions & 3 deletions test/known_issues/test-vm-timeout-escape-nexttick.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ for (let i = 0; i < 4; i++) {
{
hrtime,
nextTick,
loop
loop,
},
{ timeout: common.platformTimeout(10) }
{ timeout: common.platformTimeout(10) },
);
}, {
code: 'ERR_SCRIPT_EXECUTION_TIMEOUT'
code: 'ERR_SCRIPT_EXECUTION_TIMEOUT',
});
}
6 changes: 3 additions & 3 deletions test/known_issues/test-vm-timeout-escape-queuemicrotask.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ assert.throws(() => {
{
hrtime,
queueMicrotask,
loop
loop,
},
{ timeout, microtaskMode: 'afterScriptRun' }
{ timeout, microtaskMode: 'afterScriptRun' },
);
}, {
code: 'ERR_SCRIPT_EXECUTION_TIMEOUT',
message: `Script execution timed out after ${timeout}ms`
message: `Script execution timed out after ${timeout}ms`,
});

0 comments on commit c7f29b2

Please sign in to comment.