fixup! fixup! fixup! fixup! fixup! test,debugger: migrate node-inspec…

…t tests to core
nodejs · Apr 10, 2021 · d1647d4 · d1647d4
1 parent c9e09fc
commit d1647d4
Showing 1 changed file with 21 additions and 7 deletions.
diff --git a/test/common/inspector-cli.js b/test/common/inspector-cli.js
@@ -14,11 +14,15 @@ function isPreBreak(output) {
 }
 
 function startCLI(args, flags = [], spawnOpts = {}) {
+  let stderrOutput = '';
   const child =
     spawn(process.execPath, [...flags, 'inspect', ...args], spawnOpts);
 
   const outputBuffer = [];
   function bufferOutput(chunk) {
+    if (this === child.stderr) {
+      stderrOutput += chunk;
+    }
     outputBuffer.push(chunk);
   }
 
@@ -32,7 +36,7 @@ function startCLI(args, flags = [], spawnOpts = {}) {
   child.stderr.on('data', bufferOutput);
 
   if (process.env.VERBOSE === '1') {
-    child.stdout.pipe(process.stderr);
+    child.stdout.pipe(process.stdout);
     child.stderr.pipe(process.stderr);
   }
 
@@ -59,10 +63,20 @@ function startCLI(args, flags = [], spawnOpts = {}) {
           }
         }
 
-        function onChildExit() {
+        function onChildClose(code, signal) {
           tearDown();
-          reject(new Error(
-            `Child quit while waiting for ${pattern}; found: ${this.output}`));
+          let message = 'Child exited';
+          if (code) {
+            message += `, code ${code}`;
+          }
+          if (signal) {
+            message += `, signal ${signal}`;
+          }
+          message += ` while waiting for ${pattern}; found: ${this.output}`;
+          if (stderrOutput) {
+            message += `\n STDERR: ${stderrOutput}`;
+          }
+          reject(new Error(message));
         }
 
         const timer = setTimeout(() => {
@@ -76,10 +90,10 @@ function startCLI(args, flags = [], spawnOpts = {}) {
         function tearDown() {
           clearTimeout(timer);
           child.stdout.removeListener('data', checkOutput);
-          child.removeListener('exit', onChildExit);
+          child.removeListener('close', onChildClose);
         }
 
-        child.on('exit', onChildExit);
+        child.on('close', onChildClose);
         child.stdout.on('data', checkOutput);
         checkOutput();
       });
@@ -156,7 +170,7 @@ function startCLI(args, flags = [], spawnOpts = {}) {
     quit() {
       return new Promise((resolve) => {
         child.stdin.end();
-        child.on('exit', resolve);
+        child.on('close', resolve);
       });
     },
   };