tools: autofixer for lowercase-name-for-primitive

PR-URL: #17715 Refs: #16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>
nodejs · Jan 24, 2018 · f88afb4 · f88afb4
1 parent d7f74dd
commit f88afb4
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 12 deletions.
diff --git a/test/parallel/test-eslint-lowercase-name-for-primitive.js b/test/parallel/test-eslint-lowercase-name-for-primitive.js
@@ -22,20 +22,28 @@ new RuleTester().run('lowercase-name-for-primitive', rule, {
   ],
   invalid: [
     {
-      code: 'new errors.TypeError("ERR_INVALID_ARG_TYPE", "a", "Number")',
-      errors: [{ message: 'primitive should use lowercase: Number' }]
+      code: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' +
+            '\'Number\')',
+      errors: [{ message: 'primitive should use lowercase: Number' }],
+      output: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' +
+              '\'number\')'
     },
     {
-      code: 'new errors.TypeError("ERR_INVALID_ARG_TYPE", "a", "STRING")',
-      errors: [{ message: 'primitive should use lowercase: STRING' }]
+      code: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' +
+            '\'STRING\')',
+      errors: [{ message: 'primitive should use lowercase: STRING' }],
+      output: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' +
+               '\'string\')'
     },
     {
-      code: 'new errors.TypeError("ERR_INVALID_ARG_TYPE", "a",' +
-            '["String", "Number"])',
+      code: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' +
+            '[\'String\', \'Number\']) ',
       errors: [
         { message: 'primitive should use lowercase: String' },
         { message: 'primitive should use lowercase: Number' }
-      ]
+      ],
+      output: 'new errors.TypeError(\'ERR_INVALID_ARG_TYPE\', \'a\', ' +
+              '[\'string\', \'number\']) '
     }
   ]
 });
diff --git a/tools/eslint-rules/lowercase-name-for-primitive.js b/tools/eslint-rules/lowercase-name-for-primitive.js
@@ -22,22 +22,33 @@ module.exports = function(context) {
 
     switch (names.type) {
       case 'Literal':
-        checkName(node, names.value);
+        checkName(names);
         break;
       case 'ArrayExpression':
         names.elements.forEach((name) => {
-          checkName(node, name.value);
+          checkName(name);
         });
         break;
     }
   }
 
-  function checkName(node, name) {
+  function checkName(node) {
+    const name = node.value;
     const lowercaseName = name.toLowerCase();
-    if (primitives.includes(lowercaseName) && !primitives.includes(name)) {
+    if (name !== lowercaseName && primitives.includes(lowercaseName)) {
       const msg = `primitive should use lowercase: ${name}`;
-      context.report(node, msg);
+      context.report({
+        node,
+        message: msg,
+        fix: (fixer) => {
+          return fixer.replaceText(
+            node,
+            `'${lowercaseName}'`
+          );
+        }
+      });
     }
+
   }
 
   return {