Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The testing guide does not mention where a test should be added #18774

Closed
joyeecheung opened this issue Feb 14, 2018 · 3 comments
Closed

The testing guide does not mention where a test should be added #18774

joyeecheung opened this issue Feb 14, 2018 · 3 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Feb 14, 2018

https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md

  1. It does not mention how to determine which folder a new test should go to: parallel, sequential, or any other folders under test
    2. It does not mention how the test should be named (if it's a new test script) It does
  2. It does not mention how to find existing test cases and how to decide if a new test case belongs to a new file or an existing file.
@joyeecheung joyeecheung added the doc Issues and PRs related to the documentations. label Feb 14, 2018
@juggernaut451
Copy link
Contributor

@joyeecheung could you please ellaborate when should one test be gone under parallel or any other folder?

@joyeecheung
Copy link
Member Author

@juggernaut451 See https://github.com/nodejs/node/tree/master/test#test-directories. In practice, most tests go into parallel unless there is something special about them that they need to be put in other directories.

@juggernaut451
Copy link
Contributor

I am working on this issue

juggernaut451 added a commit to juggernaut451/node that referenced this issue Feb 17, 2018
targos pushed a commit that referenced this issue Mar 27, 2018
PR-URL: #18802
Fixes: #18774
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this issue Dec 3, 2018
PR-URL: #18802
Fixes: #18774
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

No branches or pull requests

2 participants