Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/doctool/test-make-doc.js fails if .DS_Store exists #21519

Closed
devsnek opened this issue Jun 25, 2018 · 5 comments
Closed

test/doctool/test-make-doc.js fails if .DS_Store exists #21519

devsnek opened this issue Jun 25, 2018 · 5 comments
Labels
doc Issues and PRs related to the documentations. test Issues and PRs related to the tests.

Comments

@devsnek
Copy link
Member

devsnek commented Jun 25, 2018 

=== release test-make-doc ===
Path: doctool/test-make-doc
assert.js:270
    throw err;
    ^

AssertionError [ERR_ASSERTION]: .DS_Store does not not match TOC
    at Object.<anonymous> (test/doctool/test-make-doc.js:44:10)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:260:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:584:3)
Command: out/Release/node test/doctool/test-make-doc.js
@devsnek devsnek added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. labels Jun 25, 2018
@vsemozhetbyt vsemozhetbyt mentioned this issue Jun 25, 2018
Closed
3 tasks
@vsemozhetbyt
Copy link
Contributor

PR to fix: #21531

targos pushed a commit that referenced this issue Jun 28, 2018
@vsemozhetbyt @targos
test: skip non-doc files in test-make-doc checks
623cf11 
PR-URL: #21531
Fixes: #21519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@devsnek
Copy link
Member Author

devsnek commented Jul 14, 2018 

=== release test-make-doc ===
Path: doctool/test-make-doc
assert.js:270
    throw err;
    ^

AssertionError [ERR_ASSERTION]: _toc.html does not not match TOC
    at Object.<anonymous> (/Users/gus/Desktop/misc/nodejs/node/test/doctool/test-make-doc.js:45:10)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:266:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:595:3)
Command: out/Release/node /Users/gus/Desktop/misc/nodejs/node/test/doctool/test-make-doc.js

/cc @vsemozhetbyt

@devsnek devsnek reopened this Jul 14, 2018
@vsemozhetbyt
Copy link
Contributor

Just delete _toc.html or clean the out/doc folder: we have no _toc.* files anymore.

@vsemozhetbyt
Copy link
Contributor

Refs: _toc.md was deleted in the #21637 and _toc.html is not generated anymore, so it seems it is just an artifact from the previous builds.

@lundibundi
Copy link
Member

lundibundi commented Aug 1, 2018 •
edited

@devsnek that is #21912. It is now resolved by adding a new log to the error of suggesting to remove the relevant file.
Should be resolved.

@devsnek devsnek closed this as completed Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@devsnek @lundibundi @vsemozhetbyt