Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip non-doc files in test-make-doc checks #21531

Closed
wants to merge 1 commit into from
Closed

test: skip non-doc files in test-make-doc checks #21531

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Fixes: #21519

@nodejs-github-bot
Copy link
Collaborator

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/157/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jun 25, 2018
@vsemozhetbyt vsemozhetbyt mentioned this pull request Jun 25, 2018
Closed
@vsemozhetbyt
Copy link
Contributor Author

Full CI: https://ci.nodejs.org/job/node-test-pull-request/15612/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 25, 2018
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Jun 25, 2018 •
edited
Loading

Windows failures seem unrelated.
Rerun: https://ci.nodejs.org/job/node-test-commit-windows-fanned/18965/ (green).

vsemozhetbyt added a commit that referenced this pull request Jun 27, 2018
@vsemozhetbyt
test: skip non-doc files in test-make-doc checks
759809f 
PR-URL: #21531
Fixes: #21519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 759809f
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the test-make-doc-narrow branch June 27, 2018 20:15
targos pushed a commit that referenced this pull request Jun 28, 2018
@vsemozhetbyt @targos
test: skip non-doc files in test-make-doc checks
623cf11 
PR-URL: #21531
Fixes: #21519
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@devsnek devsnek devsnek approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vsemozhetbyt @nodejs-github-bot @lpinca @devsnek @trivikr