Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update what’s off without Intl #2300

Closed
srl295 opened this issue Aug 4, 2015 · 8 comments
Closed

doc: update what’s off without Intl #2300

srl295 opened this issue Aug 4, 2015 · 8 comments
Assignees
Labels
doc Issues and PRs related to the documentations. i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Aug 4, 2015

Following may not behave as desired without Intl support:

cc: #238

@srl295 srl295 self-assigned this Aug 4, 2015
@srl295 srl295 added the doc Issues and PRs related to the documentations. label Aug 4, 2015
@silverwind
Copy link
Contributor

Some of these are prototype-only. Here's what I found though checking repl autocomplete:

String.toLocaleString
String.prototype.normalize
String.prototype.localeCompare
String.prototype.toLocaleString
String.prototype.toLocaleLowerCase
String.prototype.toLocaleUpperCase

Date.toLocaleString
Date.prototype.toLocaleString
Date.prototype.toLocaleDateString
Date.prototype.toLocaleTimeString

Number.toLocaleString
Number.prototype.toLocaleString

@silverwind silverwind added the i18n-api Issues and PRs related to the i18n implementation. label Aug 10, 2015
@srl295
Copy link
Member Author

srl295 commented Aug 11, 2015

@silverwind thanks! I missed the casing ones - very important. Also need to check if regex changed..

@silverwind
Copy link
Contributor

Also let's not forget about the Intl object itself. I'm wondering where to put these docs actually. Maybe we need a dedicated section for differences between browser and node APIs (atob() and btoa() come to mind).

@srl295
Copy link
Member Author

srl295 commented Aug 25, 2015

@nodejs/documentation any thoughts?

@srl295
Copy link
Member Author

srl295 commented Oct 24, 2015

  • TODO: put in wiki/Intl for now.

@jasnell
Copy link
Member

jasnell commented Apr 2, 2016

@srl295 ... any reason to keep this open?

@jasnell
Copy link
Member

jasnell commented Apr 3, 2016

Closing this for now, does not appear to be anything actionable just yet.

@TimothyGu
Copy link
Member

TimothyGu commented Dec 17, 2017

This got fixed by #13916, specifically the table in https://nodejs.org/api/intl.html#intl_options_for_building_node_js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Development

No branches or pull requests

4 participants