New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add documentation on ICU #13916

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@TimothyGu
Member

TimothyGu commented Jun 26, 2017

Adapted from the wiki article "Intl" by @srl295. Open to suggestions w.r.t. where this page belongs best, either here or on nodejs.org, but somewhere more permanent than a wiki.

Refs: #13644 (comment)

Checklist
Affected core subsystem(s)

doc

@TimothyGu TimothyGu requested a review from srl295 Jun 26, 2017

@TimothyGu TimothyGu added the intl label Jun 26, 2017

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Jun 26, 2017

Member

If it remains in the api, it should also be added to all.md

Member

vsemozhetbyt commented Jun 26, 2017

If it remains in the api, it should also be added to all.md

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
Member

vsemozhetbyt commented Jun 26, 2017

Show outdated Hide outdated doc/api/intl.md
Show outdated Hide outdated doc/api/intl.md
Show outdated Hide outdated doc/api/intl.md
@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Jun 27, 2017

Member

@jasnell Comments are addressed. What are your thoughts on where this document should end up?

Member

TimothyGu commented Jun 27, 2017

@jasnell Comments are addressed. What are your thoughts on where this document should end up?

@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Jul 5, 2017

Member

I'll merge this tomorrow if there are no more comments.

Member

TimothyGu commented Jul 5, 2017

I'll merge this tomorrow if there are no more comments.

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Jul 5, 2017

Member

Linter (you may need to rebase after the 15599cb):

  96:1  error  Expected indentation of 0 spaces but found 2  indent
  98:1  error  Expected indentation of 0 spaces but found 2  indent
  99:1  error  Expected indentation of 0 spaces but found 2  indent
Member

vsemozhetbyt commented Jul 5, 2017

Linter (you may need to rebase after the 15599cb):

  96:1  error  Expected indentation of 0 spaces but found 2  indent
  98:1  error  Expected indentation of 0 spaces but found 2  indent
  99:1  error  Expected indentation of 0 spaces but found 2  indent

TimothyGu added some commits Jun 26, 2017

use relative links to api docs
Looks like this is staying in node/node.
@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Jul 5, 2017

Member

Not too big of a fan of the linter change, but changed.

Linter CI: https://ci.nodejs.org/job/node-test-linter/10274/

Member

TimothyGu commented Jul 5, 2017

Not too big of a fan of the linter change, but changed.

Linter CI: https://ci.nodejs.org/job/node-test-linter/10274/

@vsemozhetbyt

This comment has been minimized.

Show comment
Hide comment
@vsemozhetbyt

vsemozhetbyt Jul 5, 2017

Member

@TimothyGu It seems it is due to 7477f9b, but I wanted to be on safe side with updated tools)

Member

vsemozhetbyt commented Jul 5, 2017

@TimothyGu It seems it is due to 7477f9b, but I wanted to be on safe side with updated tools)

@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Jul 6, 2017

Member

Landed in 6809429

Member

TimothyGu commented Jul 6, 2017

Landed in 6809429

@TimothyGu TimothyGu closed this Jul 6, 2017

@TimothyGu TimothyGu deleted the TimothyGu:intl-doc branch Jul 6, 2017

TimothyGu added a commit that referenced this pull request Jul 6, 2017

doc: add documentation on ICU
PR-URL: #13916
Refs: #13644 (comment)
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

addaleax added a commit that referenced this pull request Jul 11, 2017

doc: add documentation on ICU
PR-URL: #13916
Refs: #13644 (comment)
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

@addaleax addaleax referenced this pull request Jul 11, 2017

Merged

v8.2.0 proposal #13744

addaleax added a commit that referenced this pull request Jul 18, 2017

doc: add documentation on ICU
PR-URL: #13916
Refs: #13644 (comment)
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

Fishrock123 added a commit that referenced this pull request Jul 19, 2017

doc: add documentation on ICU
PR-URL: #13916
Refs: #13644 (comment)
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Aug 15, 2017

Member

Is this applicable to v6.x? It is easy enough to land this but I want to ensure that it makes sense for the version of ICU that is embedded

6.x: 58.2
8.x: 59.1

Member

MylesBorins commented Aug 15, 2017

Is this applicable to v6.x? It is easy enough to land this but I want to ensure that it makes sense for the version of ICU that is embedded

6.x: 58.2
8.x: 59.1

@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Aug 15, 2017

Member

@MylesBorins Yep, most of the content is applicable to 6.x as well, but some things need to be changed (e.g. mentions of the WHATWG URL API as it doesn't exist in 6.x).

Member

TimothyGu commented Aug 15, 2017

@MylesBorins Yep, most of the content is applicable to 6.x as well, but some things need to be changed (e.g. mentions of the WHATWG URL API as it doesn't exist in 6.x).

@srl295

post merge 👍

TimothyGu added a commit to TimothyGu/node that referenced this pull request Sep 12, 2017

doc: add documentation on ICU
PR-URL: nodejs#13916
Refs: nodejs#13644 (comment)
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

@TimothyGu TimothyGu referenced this pull request Sep 12, 2017

Closed

[v6.x backport] doc: add documentation on ICU #15353

2 of 2 tasks complete

TimothyGu added a commit to TimothyGu/node that referenced this pull request Sep 15, 2017

doc: add documentation on ICU
PR-URL: nodejs#13916
Refs: nodejs#13644 (comment)
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 19, 2017

doc: add documentation on ICU
PR-URL: #13916
Refs: #13644 (comment)
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment